Misc fixes for VNC
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 0 repliesNew
- v13 patches 11 repliesSuperseded
Changes in v2 from the cover letter
- Improve error reporting when VNC feature is disabled at build time
- Move VNC auth scheme setup into separate method
- Split the 3rd patch up into 4 pieces
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | ui: remove unused 'wiremode' variable in VncState structui/ ui/ ui/ +1 more | +0 | 0 replies | |
| 2/8 | ui: replace printf() calls with VNC_DEBUGui/ | +6 | 0 replies | |
| 3/8 | ui: report error if user requests VNC option that is unsupportedui/ ui/ | +23 | 0 replies | |
| 4/8 | ui: split setup of VNC auth scheme into separate methodui/ | +91 | 0 replies | |
| 5/8 | ui: fix setup of VNC websockets auth scheme with TLSui/ ui/ | +52 | 0 replies | |
| 6/8 | ui: enforce TLS when using websockets serverui/ ui/ ui/ | +9 | 0 replies | |
| 7/8 | ui: remove separate gnutls_session for websockets serverui/ ui/ ui/ +1 more | +33 | 0 replies | |
| 8/8 | ui: ensure VNC websockets server checks the ACL if requestedui/ | +10 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [Qemu-devel] [PATCH v2 0/8] Misc fixes for VNC
This is a small series of fixes for the VNC server. The primary focus was on fixing the handling of TLS + auth in the websockets server so that it can actually be used in real world scenarios. These prepare the way for work I'm doing to refactor TLS handling into a module that is reusable across QEMU.
Changed in v2:
- Improve error reporting when VNC feature is disabled at build time
- Move VNC auth scheme setup into separate method
- Split the 3rd patch up into 4 pieces
Daniel P. Berrange (8):
ui: remove unused 'wiremode' variable in VncState struct
ui: replace printf() calls with VNC_DEBUG
ui: report error if user requests VNC option that is unsupported
ui: split setup of VNC auth scheme into separate method
ui: fix setup of VNC websockets auth scheme with TLS
ui: enforce TLS when using websockets server
ui: remove separate gnutls_session for websockets server
ui: ensure VNC websockets server checks the ACL if requested
ui/vnc-auth-vencrypt.c | 1 - ui/vnc-tls.c | 72 +++++-------- ui/vnc-tls.h | 7 -- ui/vnc-ws.c | 46 ++++---- ui/vnc-ws.h | 2 +- ui/vnc.c | 287 +++++++++++++++++++++++++++++-------------------- ui/vnc.h | 9 +- 7 files changed, 222 insertions(+), 202 deletions(-)
Signature · 1 line
2.1.0