SUSE SLES resync
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest78 patches 19 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/78 | libmultipath: remove compilation warning in devmapper.clibmultipath/ | +2 | 0 replies | |
| 2/78 | mpath_persist: Do not call exit() from a shared librarylibmpathpersist/ | +31 | 0 replies | |
| 3/78 | libmultipath: filter for missing property in get_refwwid()libmultipath/ | +6 | 0 replies | |
| 4/78 | Double uevent stacksize yet againlibmultipath/ multipathd/ | +2 | 0 replies | |
| 5/78 | discovery: do not fail discovery on individual deviceslibmpathpersist/ libmultipath/ libmultipath/ +2 more | +38 | 0 replies | |
| 6/78 | libmultipath: Prefer deprecated 'getuid' calloutlibmultipath/ | +3 | 0 replies | |
| 7/78 | libmultipath: Skip paths with empty wwidlibmultipath/ | +4 | 0 replies | |
| 8/78 | Make systemd installation path configurableMakefile.inc | +6 | 0 replies | |
| 9/78 | Add multipath rules for systemd supportmultipath/ multipath/ | +15 | 0 replies | |
| 10/78 | Fixup multipathd.socket to resolve ordering dependenymultipathd/ multipathd/ | +7 | 0 replies | |
| 11/78 | Fixup dependencies in multipathd.servicemultipathd/ | +2 | 0 replies | |
| 12/78 | multipathd: set correct PID when running in debug modemultipathd/ | +1 | 0 replies | |
| 13/78 | Do not print empty device strings during discoverylibmultipath/ | +6 | 0 replies | |
| 14/78 | kpartx.rules: do not call blkidkpartx/ | +0 | 0 replies | |
| 15/78 | Use 'SCSI_IDENT_.*' as the default property whitelistlibmultipath/ | +1 | 0 replies | |
| 16/78 | Fixup wwid blacklist printinglibmultipath/ libmultipath/ libmultipath/ +2 more | +8 | 0 replies | |
| 17/78 | Allow for empty path argument when printing informationlibmultipath/ | +16 | 0 replies | |
| 18/78 | Disable reassign maps per defaultlibmultipath/ | +1 | 0 replies | |
| 19/78 | multipathd: implement 'list path <path>' cli commandmultipathd/ multipathd/ multipathd/ +1 more | +47 | 0 replies | |
| 20/78 | Make checker_put() and prio_put() idempotentlibmultipath/ libmultipath/ | +3 | 0 replies | |
| 21/78 | Remove trailing linefeed from sysfs attributeslibmultipath/ | +2 | 0 replies | |
| 22/78 | multipath: implement option '-u' for ueventslibmultipath/ libmultipath/ libmultipath/ +4 more | +54 | 0 replies | |
| 23/78 | Install multipath rule under '56-multipath.rules'multipath/ | +2 | 0 replies | |
| 24/78 | multipath.rules: Whitelist devicesmultipath/ | +1 | 0 replies | |
| 25/78 | multipath.rules: fixup race condition with systemdmultipath/ | +2 | 0 replies | |
| 26/78 | 11-dm-mpath.rules: Import blkid values if all paths are downmultipath/ | +7 | 3 replies | |
| 27/78 | kpartx.rules: Skip kpartx for multipath eventskpartx/ | +2 | 0 replies | |
| 28/78 | multipathd: handle DOMAP_RETRYmultipathd/ | +10 | 0 replies | |
| 29/78 | multipathd: cleanup foreground operationmultipathd/ | +5 | 0 replies | |
| 30/78 | Update hwtable for EMC XtremIOlibmultipath/ | +13 | 0 replies | |
| 31/78 | multipath: check for running daemon when called with '-u'multipath/ | +13 | 0 replies | |
| 32/78 | Revert 'return PATH_DOWN for quiesced paths'libmultipath/ | +0 | 0 replies | |
| 33/78 | Do not treat 'transport-offline' paths as 'offline'libmultipath/ | +1 | 0 replies | |
| 34/78 | Check for valid DM_DEVICE_INFO before proceedinglibmultipath/ | +9 | 0 replies | |
| 35/78 | Separate out uevent parsing functionslibmultipath/ | +136 | 0 replies | |
| 36/78 | Use poll() when receiving ueventslibmultipath/ libmultipath/ | +95 | 0 replies | |
| 37/78 | mpath_persist: cleanuplibmpathpersist/ libmpathpersist/ | +58 | 0 replies | |
| 38/78 | kpartx: use standard 'major' and 'minor' macroskpartx/ kpartx/ | +9 | 0 replies | |
| 39/78 | multipath: Use standard 'major' macromultipath/ multipath/ | +1 | 0 replies | |
| 40/78 | Remove sysfs_get_devlibmultipath/ libmultipath/ libmultipath/ | +7 | 0 replies | |
| 41/78 | Add paths with a size of '0' as 'ghost' pathslibmultipath/ libmultipath/ multipathd/ | +11 | 0 replies | |
| 42/78 | Remove last argument from verify_paths()libmultipath/ libmultipath/ libmultipath/ +1 more | +8 | 0 replies | |
| 43/78 | Fixup device-mapper 'cookie' handlingkpartx/ kpartx/ kpartx/ +6 more | +94 | 3 replies | |
| 44/78 | multipath: do not print state 'orphan' for option '-l'libmultipath/ | +0 | 0 replies | |
| 45/78 | Return error when receiving CLI packetlibmpathpersist/ libmultipath/ libmultipath/ +6 more | +57 | 0 replies | |
| 46/78 | Implement 'uxsock_timeout' keywordlibmultipath/ libmultipath/ libmultipath/ +3 more | +48 | 0 replies | |
| 47/78 | Do not print empty multipaths sectionmultipath/ multipathd/ | +13 | 0 replies | |
| 48/78 | multipathd: reload map if reinstate failedmultipathd/ | +23 | 0 replies | |
| 49/78 | multipathd: do not remove paths without ueventsmultipathd/ | +8 | 0 replies | |
| 50/78 | Allow zero-sized devices during configurationlibmultipath/ | +6 | 2 replies | |
| 51/78 | Rework uev_add_path()libmultipath/ libmultipath/ libmultipath/ +1 more | +82 | 0 replies | |
| 52/78 | multipathd: Issue warning on CLI command timeoutmultipathd/ multipathd/ | +52 | 0 replies | |
| 53/78 | Use strlen() when checking for valid wwidlibmultipath/ multipathd/ | +2 | 0 replies | |
| 54/78 | multipathd: Use standard lists for CLI handlinglibmultipath/ libmultipath/ multipathd/ | +29 | 0 replies | |
| 55/78 | uxlsnr: use typedef for trigger functionmultipathd/ multipathd/ | +6 | 0 replies | |
| 56/78 | multipathd: lock cli client listmultipathd/ | +16 | 0 replies | |
| 57/78 | multipath: enable sync supportmultipath/ | +1 | 0 replies | |
| 58/78 | Remove dm_udev_XXX wrapper functionslibmultipath/ libmultipath/ multipath/ +1 more | +7 | 0 replies | |
| 59/78 | Revert to ACT_RELOAD in domap if the map existslibmultipath/ libmultipath/ | +12 | 0 replies | |
| 60/78 | multipathd: use local variable for watchdog configurationlibmultipath/ multipathd/ | +6 | 0 replies | |
| 61/78 | Ignore devices when sysfs_get_tgt_nodename failslibmultipath/ | +7 | 0 replies | |
| 62/78 | Skip USB devices during discoverylibmultipath/ | +13 | 0 replies | |
| 63/78 | Read wwid from sysfs vpg_pg83 attributelibmultipath/ libmultipath/ libmultipath/ | +331 | 0 replies | |
| 64/78 | Assign local priority for NAA VPD descriptorlibmultipath/ | +25 | 0 replies | |
| 65/78 | Use sysfs attribute vpd_pg80 to read serial numberlibmultipath/ | +28 | 0 replies | |
| 66/78 | Update multipath.conf.5 to clarify wwid generationmultipath.conf.defaults multipath/ | +29 | 0 replies | |
| 67/78 | libmultipath: Fall back to SG_IO if no UID could be assignedlibmultipath/ | +39 | 0 replies | |
| 68/78 | libmultipath: unset 'uid_attribute' on failurelibmultipath/ | +7 | 2 replies | |
| 69/78 | Separate out vpd parsing functionslibmultipath/ | +193 | 0 replies | |
| 70/78 | multipathd: use SG_IO as fallback to generate uidlibmultipath/ | +50 | 0 replies | |
| 71/78 | Do not automatically fall back to vpd uid generationlibmultipath/ | +16 | 0 replies | |
| 72/78 | libmultipath: make vpd page 0x80 optionallibmultipath/ | +2 | 0 replies | |
| 73/78 | multipathd: push down lock in checkerloop()multipathd/ | +12 | 1 reply | |
| 74/78 | Allow specific CLI commands to run unlockedmultipathd/ multipathd/ multipathd/ | +33 | 1 reply | |
| 75/78 | Push down vector lock during uevent processingmultipathd/ | +48 | 1 reply | |
| 76/78 | multipathd: timeout CLI commands when waiting for locklibmultipath/ libmultipath/ libmultipath/ +6 more | +50 | 0 replies | |
| 77/78 | multipathd: asynchronous configurationmultipathd/ multipathd/ multipathd/ | +51 | 2 replies | |
| 78/78 | multipathd: trigger all devices on startuplibmultipath/ libmultipath/ multipathd/ | +85 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/78] SUSE SLES resync
Hi Christophe,
here are the patches which I've queued up during SLES12 development. Most of them are (more or less) obvious bugfixes, but there are some things which would warrant a deeper review:
- device-mapper cookie handling: This _really_ is an arcane topic, and I would love to have someone from the device-mapper team to review it. I'm still facing some issues where udev emits a warning 'conflicting device node /dev/mapper/XXX ..', so there might be some issue with it.
- Asynchronous configuration: On large systems configure() as being called during multipathd startup might exceed the systemd job timeout, resulting in multipathd being killed by systemd. For that I've been implementing an udev retrigger method, which just issues an 'add' event for all available block devices.
- Related to the above: I've implemented an asynchronous 'reconfigure' CLI call, as for the same reason systemd might kill the multipathd during a 'restart' operation
- systemd/udev integration: This is _a pain_. It took me months to come up with a working solution. _Especially_ as apparently RH is shipping an '11-dm-multipath.rules' udev ruleset for multipathd, which supposedly should be handling this.
It didn't do it for me, though, so I've attached my own version here. The udev integration I've been settling for works like this:
- 11-dm-mpath.rules checks if the device is eligible for multipathing For that I've implemented a new option '-u' which looks at the uevent variables _only_.
- if a device should be handled by multipathing the 'by-id' and 'by-uuid' persistent symlinks are _not_ generated, as this would trigger systemd to start scanning/mounting/lvm activation/whatnot; the 'by-id' and 'by-uuid' symlinks are only generated for the multipath devices themselves.
- I've added a new multipath.rules file which should be inserted between 55-scsi-sg3_id.rules and 58-scsi_sg3_symlink.rules. This will intercept the SCSI IDENT variables and blank them out if the (block) device is handled by multipathing.
- sysfs VPD page handling. I've planned to implement this as a direct replacement of the original scsi_id program, but then it turned out that our WWID handling is actually too generic for that: Both getuid and uid_attribute can basically take _any_ value, so it's impossible to tell if the system uses the original (scsi_id compatible) IDs or not. And as the VPD parsing code can only generate scsi_id compatible IDs we might run into compability issues.
So it's disabled per default. I'd really would like to clean it up, as I suspect that about 95% of the installations are using scsi_id compatible IDs. But for this to happen we need to clarify/restrict the ID generation mechanism.
As usual, comments and reviews are welcome.
The patchset is based upon the 'find_multipaths' patchset from Ben Marzinski; it can be retrieved from
github.com:/hreinecke/multipath-tools.git branch suse-resync
Cheers,
Hannes
Hannes Reinecke (78):
libmultipath: remove compilation warning in devmapper.c
mpath_persist: Do not call exit() from a shared library
libmultipath: filter for missing property in get_refwwid() Double uevent stacksize yet again
discovery: do not fail discovery on individual devices
libmultipath: Prefer deprecated 'getuid' callout
libmultipath: Skip paths with empty wwid
Make systemd installation path configurable
Add multipath rules for systemd support
Fixup multipathd.socket to resolve ordering dependeny Fixup dependencies in multipathd.service
multipathd: set correct PID when running in debug mode Do not print empty device strings during discovery kpartx.rules: do not call blkid
Use 'SCSI_IDENT_.*' as the default property whitelist Fixup wwid blacklist printing
Allow for empty path argument when printing information Disable reassign maps per default
multipathd: implement 'list path <path>' cli command Make checker_put() and prio_put() idempotent Remove trailing linefeed from sysfs attributes
multipath: implement option '-u' for uevents Install multipath rule under '56-multipath.rules' multipath.rules: Whitelist devices multipath.rules: fixup race condition with systemd 11-dm-mpath.rules: Import blkid values if all paths are down kpartx.rules: Skip kpartx for multipath events
multipathd: handle DOMAP_RETRY
multipathd: cleanup foreground operation
Update hwtable for EMC XtremIO
multipath: check for running daemon when called with '-u' Revert 'return PATH_DOWN for quiesced paths'
Do not treat 'transport-offline' paths as 'offline' Check for valid DM_DEVICE_INFO before proceeding Separate out uevent parsing functions
Use poll() when receiving uevents
mpath_persist: cleanup
kpartx: use standard 'major' and 'minor' macros
multipath: Use standard 'major' macro
Remove sysfs_get_dev
Add paths with a size of '0' as 'ghost' paths Remove last argument from verify_paths()
Fixup device-mapper 'cookie' handling
multipath: do not print state 'orphan' for option '-l' Return error when receiving CLI packet
Implement 'uxsock_timeout' keyword
Do not print empty multipaths section
multipathd: reload map if reinstate failed
multipathd: do not remove paths without uevents Allow zero-sized devices during configuration Rework uev_add_path()
multipathd: Issue warning on CLI command timeout Use strlen() when checking for valid wwid
multipathd: Use standard lists for CLI handling
uxlsnr: use typedef for trigger function
multipathd: lock cli client list
multipath: enable sync support
Remove dm_udev_XXX wrapper functions
Revert to ACT_RELOAD in domap if the map exists
multipathd: use local variable for watchdog configuration Ignore devices when sysfs_get_tgt_nodename fails Skip USB devices during discovery
Read wwid from sysfs vpg_pg83 attribute
Assign local priority for NAA VPD descriptor
Use sysfs attribute vpd_pg80 to read serial number Update multipath.conf.5 to clarify wwid generation
libmultipath: Fall back to SG_IO if no UID could be assigned
libmultipath: unset 'uid_attribute' on failure Separate out vpd parsing functions
multipathd: use SG_IO as fallback to generate uid Do not automatically fall back to vpd uid generation
libmultipath: make vpd page 0x80 optional
multipathd: push down lock in checkerloop()
Allow specific CLI commands to run unlocked
Push down vector lock during uevent processing
multipathd: timeout CLI commands when waiting for lock
multipathd: asynchronous configuration
multipathd: trigger all devices on startup
Makefile.inc | 8 +- kpartx/devmapper.c | 53 +++- kpartx/devmapper.h | 11 +- kpartx/kpartx.c | 35 +-- kpartx/kpartx.rules | 10 +- libmpathpersist/mpath_persist.c | 172 ++++++----- libmpathpersist/mpath_updatepr.c | 20 +- libmpathpersist/mpathpr.h | 3 +- libmultipath/blacklist.c | 8 +- libmultipath/blacklist.h | 2 +- libmultipath/checkers.c | 2 +- libmultipath/config.c | 2 + libmultipath/config.h | 8 +- libmultipath/configure.c | 82 ++++-- libmultipath/defaults.h | 4 +- libmultipath/devmapper.c | 77 +++-- libmultipath/devmapper.h | 4 +- libmultipath/dict.c | 33 +++ libmultipath/discovery.c | 613 ++++++++++++++++++++++++++++++++++----- libmultipath/discovery.h | 8 +- libmultipath/hwtable.c | 13 + libmultipath/list.h | 49 +++- libmultipath/lock.h | 4 +- libmultipath/log_pthread.c | 2 +- libmultipath/print.c | 20 +- libmultipath/prio.c | 4 +- libmultipath/propsel.c | 6 +- libmultipath/structs_vec.c | 29 +- libmultipath/structs_vec.h | 2 +- libmultipath/sysfs.c | 53 ++++ libmultipath/sysfs.h | 2 + libmultipath/uevent.c | 316 ++++++++++++-------- libmultipath/uxsock.c | 32 +- libmultipath/uxsock.h | 4 +- multipath.conf.defaults | 2 +- multipath/11-dm-mpath.rules | 8 +- multipath/Makefile | 2 + multipath/dev_t.h | 3 - multipath/main.c | 53 +++- multipath/multipath.8 | 6 +- multipath/multipath.conf.5 | 42 ++- multipath/multipath.rules | 14 + multipathd/cli.c | 47 ++- multipathd/cli.h | 4 +- multipathd/cli_handlers.c | 64 +++- multipathd/cli_handlers.h | 1 + multipathd/main.c | 400 ++++++++++++++++--------- multipathd/main.h | 2 + multipathd/multipathd.service | 4 +- multipathd/multipathd.socket | 8 +- multipathd/uxclnt.c | 26 +- multipathd/uxclnt.h | 2 +- multipathd/uxlsnr.c | 102 +++++-- multipathd/uxlsnr.h | 8 +- 54 files changed, 1834 insertions(+), 655 deletions(-) delete mode 100644 multipath/dev_t.h create mode 100644 multipath/multipath.rules
Signature · 1 line
1.8.4.5