Skip to content

SUSE SLES resync

Hannes Reinecke dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest78 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/78libmultipath: remove compilation warning in devmapper.clibmultipath/devmapper.c+2 -00 replies
2/78mpath_persist: Do not call exit() from a shared librarylibmpathpersist/mpath_persist.c+31 -210 replies
3/78libmultipath: filter for missing property in get_refwwid()libmultipath/configure.c+6 -00 replies
4/78Double uevent stacksize yet againlibmultipath/defaults.h multipathd/main.c+2 -10 replies
5/78discovery: do not fail discovery on individual deviceslibmpathpersist/mpath_persist.c libmultipath/discovery.c libmultipath/discovery.h +2 more+38 -340 replies
6/78libmultipath: Prefer deprecated 'getuid' calloutlibmultipath/propsel.c+3 -30 replies
7/78libmultipath: Skip paths with empty wwidlibmultipath/discovery.c+4 -10 replies
8/78Make systemd installation path configurableMakefile.inc+6 -20 replies
9/78Add multipath rules for systemd supportmultipath/Makefile multipath/multipath.rules+15 -00 replies
10/78Fixup multipathd.socket to resolve ordering dependenymultipathd/multipathd.service multipathd/multipathd.socket+7 -40 replies
11/78Fixup dependencies in multipathd.servicemultipathd/multipathd.service+2 -10 replies
12/78multipathd: set correct PID when running in debug modemultipathd/main.c+1 -00 replies
13/78Do not print empty device strings during discoverylibmultipath/structs_vec.c+6 -00 replies
14/78kpartx.rules: do not call blkidkpartx/kpartx.rules+0 -60 replies
15/78Use 'SCSI_IDENT_.*' as the default property whitelistlibmultipath/blacklist.c+1 -10 replies
16/78Fixup wwid blacklist printinglibmultipath/blacklist.c libmultipath/blacklist.h libmultipath/configure.c +2 more+8 -60 replies
17/78Allow for empty path argument when printing informationlibmultipath/print.c+16 -60 replies
18/78Disable reassign maps per defaultlibmultipath/defaults.h+1 -10 replies
19/78multipathd: implement 'list path <path>' cli commandmultipathd/cli.c multipathd/cli_handlers.c multipathd/cli_handlers.h +1 more+47 -00 replies
20/78Make checker_put() and prio_put() idempotentlibmultipath/checkers.c libmultipath/prio.c+3 -30 replies
21/78Remove trailing linefeed from sysfs attributeslibmultipath/sysfs.c+2 -00 replies
22/78multipath: implement option '-u' for ueventslibmultipath/config.c libmultipath/config.h libmultipath/configure.c +4 more+54 -90 replies
23/78Install multipath rule under '56-multipath.rules'multipath/Makefile+2 -20 replies
24/78multipath.rules: Whitelist devicesmultipath/multipath.rules+1 -10 replies
25/78multipath.rules: fixup race condition with systemdmultipath/multipath.rules+2 -10 replies
26/7811-dm-mpath.rules: Import blkid values if all paths are downmultipath/11-dm-mpath.rules+7 -13 replies
27/78kpartx.rules: Skip kpartx for multipath eventskpartx/kpartx.rules+2 -20 replies
28/78multipathd: handle DOMAP_RETRYmultipathd/main.c+10 -10 replies
29/78multipathd: cleanup foreground operationmultipathd/main.c+5 -20 replies
30/78Update hwtable for EMC XtremIOlibmultipath/hwtable.c+13 -00 replies
31/78multipath: check for running daemon when called with '-u'multipath/main.c+13 -00 replies
32/78Revert 'return PATH_DOWN for quiesced paths'libmultipath/discovery.c+0 -10 replies
33/78Do not treat 'transport-offline' paths as 'offline'libmultipath/discovery.c+1 -20 replies
34/78Check for valid DM_DEVICE_INFO before proceedinglibmultipath/devmapper.c+9 -00 replies
35/78Separate out uevent parsing functionslibmultipath/uevent.c+136 -1180 replies
36/78Use poll() when receiving ueventslibmultipath/list.h libmultipath/uevent.c+95 -260 replies
37/78mpath_persist: cleanuplibmpathpersist/mpath_persist.c libmpathpersist/mpathpr.h+58 -510 replies
38/78kpartx: use standard 'major' and 'minor' macroskpartx/devmapper.h kpartx/kpartx.c+9 -110 replies
39/78multipath: Use standard 'major' macromultipath/dev_t.h multipath/main.c+1 -50 replies
40/78Remove sysfs_get_devlibmultipath/discovery.c libmultipath/discovery.h libmultipath/structs_vec.c+7 -70 replies
41/78Add paths with a size of '0' as 'ghost' pathslibmultipath/discovery.c libmultipath/structs_vec.c multipathd/main.c+11 -220 replies
42/78Remove last argument from verify_paths()libmultipath/configure.c libmultipath/structs_vec.c libmultipath/structs_vec.h +1 more+8 -120 replies
43/78Fixup device-mapper 'cookie' handlingkpartx/devmapper.c kpartx/devmapper.h kpartx/kpartx.c +6 more+94 -473 replies
44/78multipath: do not print state 'orphan' for option '-l'libmultipath/print.c+0 -20 replies
45/78Return error when receiving CLI packetlibmpathpersist/mpath_updatepr.c libmultipath/configure.c libmultipath/defaults.h +6 more+57 -350 replies
46/78Implement 'uxsock_timeout' keywordlibmultipath/config.c libmultipath/config.h libmultipath/configure.c +3 more+48 -30 replies
47/78Do not print empty multipaths sectionmultipath/main.c multipathd/cli_handlers.c+13 -70 replies
48/78multipathd: reload map if reinstate failedmultipathd/main.c+23 -70 replies
49/78multipathd: do not remove paths without ueventsmultipathd/main.c+8 -50 replies
50/78Allow zero-sized devices during configurationlibmultipath/configure.c+6 -52 replies
51/78Rework uev_add_path()libmultipath/discovery.c libmultipath/discovery.h libmultipath/structs_vec.c +1 more+82 -240 replies
52/78multipathd: Issue warning on CLI command timeoutmultipathd/main.c multipathd/uxlsnr.c+52 -40 replies
53/78Use strlen() when checking for valid wwidlibmultipath/configure.c multipathd/main.c+2 -60 replies
54/78multipathd: Use standard lists for CLI handlinglibmultipath/list.h libmultipath/uxsock.c multipathd/uxlsnr.c+29 -150 replies
55/78uxlsnr: use typedef for trigger functionmultipathd/uxlsnr.c multipathd/uxlsnr.h+6 -50 replies
56/78multipathd: lock cli client listmultipathd/uxlsnr.c+16 -80 replies
57/78multipath: enable sync supportmultipath/main.c+1 -00 replies
58/78Remove dm_udev_XXX wrapper functionslibmultipath/devmapper.c libmultipath/devmapper.h multipath/main.c +1 more+7 -180 replies
59/78Revert to ACT_RELOAD in domap if the map existslibmultipath/configure.c libmultipath/devmapper.c+12 -90 replies
60/78multipathd: use local variable for watchdog configurationlibmultipath/config.h multipathd/main.c+6 -30 replies
61/78Ignore devices when sysfs_get_tgt_nodename failslibmultipath/discovery.c+7 -50 replies
62/78Skip USB devices during discoverylibmultipath/discovery.c+13 -00 replies
63/78Read wwid from sysfs vpg_pg83 attributelibmultipath/discovery.c libmultipath/sysfs.c libmultipath/sysfs.h+331 -270 replies
64/78Assign local priority for NAA VPD descriptorlibmultipath/discovery.c+25 -30 replies
65/78Use sysfs attribute vpd_pg80 to read serial numberlibmultipath/discovery.c+28 -80 replies
66/78Update multipath.conf.5 to clarify wwid generationmultipath.conf.defaults multipath/multipath.conf.5+29 -60 replies
67/78libmultipath: Fall back to SG_IO if no UID could be assignedlibmultipath/discovery.c+39 -140 replies
68/78libmultipath: unset 'uid_attribute' on failurelibmultipath/discovery.c+7 -32 replies
69/78Separate out vpd parsing functionslibmultipath/discovery.c+193 -1740 replies
70/78multipathd: use SG_IO as fallback to generate uidlibmultipath/discovery.c+50 -110 replies
71/78Do not automatically fall back to vpd uid generationlibmultipath/discovery.c+16 -230 replies
72/78libmultipath: make vpd page 0x80 optionallibmultipath/discovery.c+2 -20 replies
73/78multipathd: push down lock in checkerloop()multipathd/main.c+12 -41 reply
74/78Allow specific CLI commands to run unlockedmultipathd/cli.c multipathd/cli.h multipathd/main.c+33 -121 reply
75/78Push down vector lock during uevent processingmultipathd/main.c+48 -191 reply
76/78multipathd: timeout CLI commands when waiting for locklibmultipath/config.h libmultipath/configure.c libmultipath/dict.c +6 more+50 -310 replies
77/78multipathd: asynchronous configurationmultipathd/cli_handlers.c multipathd/main.c multipathd/main.h+51 -342 replies
78/78multipathd: trigger all devices on startuplibmultipath/discovery.c libmultipath/discovery.h multipathd/main.c+85 -42 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/78] SUSE SLES resync

Hi Christophe,

here are the patches which I've queued up during SLES12 development. Most of them are (more or less) obvious bugfixes, but there are some things which would warrant a deeper review:
- device-mapper cookie handling: This _really_ is an arcane topic, and I would love to have someone from the device-mapper team to review it. I'm still facing some issues where udev emits a warning 'conflicting device node /dev/mapper/XXX ..', so there might be some issue with it.
- Asynchronous configuration: On large systems configure() as being called during multipathd startup might exceed the systemd job timeout, resulting in multipathd being killed by systemd. For that I've been implementing an udev retrigger method, which just issues an 'add' event for all available block devices.
- Related to the above: I've implemented an asynchronous 'reconfigure' CLI call, as for the same reason systemd might kill the multipathd during a 'restart' operation
- systemd/udev integration: This is _a pain_. It took me months to come up with a working solution. _Especially_ as apparently RH is shipping an '11-dm-multipath.rules' udev ruleset for multipathd, which supposedly should be handling this.
It didn't do it for me, though, so I've attached my own version here. The udev integration I've been settling for works like this:
- 11-dm-mpath.rules checks if the device is eligible for multipathing For that I've implemented a new option '-u' which looks at the uevent variables _only_.
- if a device should be handled by multipathing the 'by-id' and 'by-uuid' persistent symlinks are _not_ generated, as this would trigger systemd to start scanning/mounting/lvm activation/whatnot; the 'by-id' and 'by-uuid' symlinks are only generated for the multipath devices themselves.
- I've added a new multipath.rules file which should be inserted between 55-scsi-sg3_id.rules and 58-scsi_sg3_symlink.rules. This will intercept the SCSI IDENT variables and blank them out if the (block) device is handled by multipathing.
- sysfs VPD page handling. I've planned to implement this as a direct replacement of the original scsi_id program, but then it turned out that our WWID handling is actually too generic for that: Both getuid and uid_attribute can basically take _any_ value, so it's impossible to tell if the system uses the original (scsi_id compatible) IDs or not. And as the VPD parsing code can only generate scsi_id compatible IDs we might run into compability issues.
So it's disabled per default. I'd really would like to clean it up, as I suspect that about 95% of the installations are using scsi_id compatible IDs. But for this to happen we need to clarify/restrict the ID generation mechanism.

As usual, comments and reviews are welcome.

The patchset is based upon the 'find_multipaths' patchset from Ben Marzinski; it can be retrieved from

github.com:/hreinecke/multipath-tools.git branch suse-resync

Cheers,

Hannes

Hannes Reinecke (78):
libmultipath: remove compilation warning in devmapper.c
mpath_persist: Do not call exit() from a shared library
libmultipath: filter for missing property in get_refwwid() Double uevent stacksize yet again
discovery: do not fail discovery on individual devices
libmultipath: Prefer deprecated 'getuid' callout
libmultipath: Skip paths with empty wwid
Make systemd installation path configurable
Add multipath rules for systemd support
Fixup multipathd.socket to resolve ordering dependeny Fixup dependencies in multipathd.service
multipathd: set correct PID when running in debug mode Do not print empty device strings during discovery kpartx.rules: do not call blkid
Use 'SCSI_IDENT_.*' as the default property whitelist Fixup wwid blacklist printing
Allow for empty path argument when printing information Disable reassign maps per default
multipathd: implement 'list path <path>' cli command Make checker_put() and prio_put() idempotent Remove trailing linefeed from sysfs attributes
multipath: implement option '-u' for uevents Install multipath rule under '56-multipath.rules' multipath.rules: Whitelist devices multipath.rules: fixup race condition with systemd 11-dm-mpath.rules: Import blkid values if all paths are down kpartx.rules: Skip kpartx for multipath events
multipathd: handle DOMAP_RETRY
multipathd: cleanup foreground operation
Update hwtable for EMC XtremIO
multipath: check for running daemon when called with '-u' Revert 'return PATH_DOWN for quiesced paths'
Do not treat 'transport-offline' paths as 'offline' Check for valid DM_DEVICE_INFO before proceeding Separate out uevent parsing functions
Use poll() when receiving uevents
mpath_persist: cleanup
kpartx: use standard 'major' and 'minor' macros
multipath: Use standard 'major' macro
Remove sysfs_get_dev
Add paths with a size of '0' as 'ghost' paths Remove last argument from verify_paths()
Fixup device-mapper 'cookie' handling
multipath: do not print state 'orphan' for option '-l' Return error when receiving CLI packet
Implement 'uxsock_timeout' keyword
Do not print empty multipaths section
multipathd: reload map if reinstate failed
multipathd: do not remove paths without uevents Allow zero-sized devices during configuration Rework uev_add_path()
multipathd: Issue warning on CLI command timeout Use strlen() when checking for valid wwid
multipathd: Use standard lists for CLI handling
uxlsnr: use typedef for trigger function
multipathd: lock cli client list
multipath: enable sync support
Remove dm_udev_XXX wrapper functions
Revert to ACT_RELOAD in domap if the map exists
multipathd: use local variable for watchdog configuration Ignore devices when sysfs_get_tgt_nodename fails Skip USB devices during discovery
Read wwid from sysfs vpg_pg83 attribute
Assign local priority for NAA VPD descriptor
Use sysfs attribute vpd_pg80 to read serial number Update multipath.conf.5 to clarify wwid generation
libmultipath: Fall back to SG_IO if no UID could be assigned
libmultipath: unset 'uid_attribute' on failure Separate out vpd parsing functions
multipathd: use SG_IO as fallback to generate uid Do not automatically fall back to vpd uid generation
libmultipath: make vpd page 0x80 optional
multipathd: push down lock in checkerloop()
Allow specific CLI commands to run unlocked
Push down vector lock during uevent processing
multipathd: timeout CLI commands when waiting for lock
multipathd: asynchronous configuration
multipathd: trigger all devices on startup

 Makefile.inc                     |   8 +-
 kpartx/devmapper.c               |  53 +++-
 kpartx/devmapper.h               |  11 +-
 kpartx/kpartx.c                  |  35 +--
 kpartx/kpartx.rules              |  10 +-
 libmpathpersist/mpath_persist.c  | 172 ++++++-----
 libmpathpersist/mpath_updatepr.c |  20 +-
 libmpathpersist/mpathpr.h        |   3 +-
 libmultipath/blacklist.c         |   8 +-
 libmultipath/blacklist.h         |   2 +-
 libmultipath/checkers.c          |   2 +-
 libmultipath/config.c            |   2 +
 libmultipath/config.h            |   8 +-
 libmultipath/configure.c         |  82 ++++--
 libmultipath/defaults.h          |   4 +-
 libmultipath/devmapper.c         |  77 +++--
 libmultipath/devmapper.h         |   4 +-
 libmultipath/dict.c              |  33 +++
 libmultipath/discovery.c         | 613 ++++++++++++++++++++++++++++++++++-----
 libmultipath/discovery.h         |   8 +-
 libmultipath/hwtable.c           |  13 +
 libmultipath/list.h              |  49 +++-
 libmultipath/lock.h              |   4 +-
 libmultipath/log_pthread.c       |   2 +-
 libmultipath/print.c             |  20 +-
 libmultipath/prio.c              |   4 +-
 libmultipath/propsel.c           |   6 +-
 libmultipath/structs_vec.c       |  29 +-
 libmultipath/structs_vec.h       |   2 +-
 libmultipath/sysfs.c             |  53 ++++
 libmultipath/sysfs.h             |   2 +
 libmultipath/uevent.c            | 316 ++++++++++++--------
 libmultipath/uxsock.c            |  32 +-
 libmultipath/uxsock.h            |   4 +-
 multipath.conf.defaults          |   2 +-
 multipath/11-dm-mpath.rules      |   8 +-
 multipath/Makefile               |   2 +
 multipath/dev_t.h                |   3 -
 multipath/main.c                 |  53 +++-
 multipath/multipath.8            |   6 +-
 multipath/multipath.conf.5       |  42 ++-
 multipath/multipath.rules        |  14 +
 multipathd/cli.c                 |  47 ++-
 multipathd/cli.h                 |   4 +-
 multipathd/cli_handlers.c        |  64 +++-
 multipathd/cli_handlers.h        |   1 +
 multipathd/main.c                | 400 ++++++++++++++++---------
 multipathd/main.h                |   2 +
 multipathd/multipathd.service    |   4 +-
 multipathd/multipathd.socket     |   8 +-
 multipathd/uxclnt.c              |  26 +-
 multipathd/uxclnt.h              |   2 +-
 multipathd/uxlsnr.c              | 102 +++++--
 multipathd/uxlsnr.h              |   8 +-
 54 files changed, 1834 insertions(+), 655 deletions(-)
 delete mode 100644 multipath/dev_t.h
 create mode 100644 multipath/multipath.rules
Signature · 1 line
1.8.4.5