Skip to content

RFC perf scripting cleanups

Arnaldo Carvalho de Melo lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf script: No need to lookup thread twicetools/perf/builtin-script.c+1 -90 replies
2/2perf scripting: No need to pass thread twice to the scripting callbackstools/perf/builtin-script.c tools/perf/util/scripting-engines/trace-event-perl.c tools/perf/util/scripting-engines/trace-event-python.c +2 more+11 -170 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNamhyung KimJiri OlsaAdrian Hunter
SeriesA-b A-b A-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFC 0/2] perf scripting cleanups

Hi David, Jiri,

Please take a look if it is ok for you guys

Adrian, there is another thing:

  db_export__sample(&tables->dbe, event, sample, evsel, al->thread, al);

In tools/perf/util/scripting-engines/trace-event-python.c has this redundancy as well, see the (al->thread, al), I'll probably remove that extra thread parm there if you don't have any other subtle use for that...

- Arnaldo

Arnaldo Carvalho de Melo (2):
perf script: No need to lookup thread twice
perf scripting: No need to pass thread twice to the scripting
callbacks

 tools/perf/builtin-script.c                            | 14 +++-----------
 tools/perf/util/scripting-engines/trace-event-perl.c   |  5 ++---
 tools/perf/util/scripting-engines/trace-event-python.c | 13 +++++--------
 tools/perf/util/trace-event-scripting.c                |  1 -
 tools/perf/util/trace-event.h                          |  3 +--
 5 files changed, 11 insertions(+), 25 deletions(-)
Signature · 1 line
1.9.3