Skip to content

ADSP Firmware Controls Update

Charles Keepax alsa-devel 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am 1428928085-20250-1-git-send-email-ckeepax@opensource.wolfsonmicro.com

Versions newest first

  1. v1 Latest13 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/13ASoC: wm_adsp: Split out adsp1 & 2 setup algorithmssound/soc/codecs/wm_adsp.c+248 -2510 replies
2/13ASoC: wm_adsp: Improve variable namingsound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h sound/soc/codecs/wmfw.h+182 -1820 replies
3/13ASoC: wm_adsp: Remove len field from wm_adsp_alg_regionsound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h+28 -280 replies
4/13ASoC: wm_adsp: Limit firmware control name to ALSA control name sizesound/soc/codecs/wm_adsp.c+2 -20 replies
5/13ASoC: wm_adsp: Move temporary control name to the stacksound/soc/codecs/wm_adsp.c+6 -170 replies
6/13ASoC: wm_adsp: Clean up low level control read/write functionssound/soc/codecs/wm_adsp.c+5 -70 replies
7/13ASoC: wm_adsp: Factor out creation of alg_regionssound/soc/codecs/wm_adsp.c+64 -700 replies
8/13ASoC: wm_adsp: Remove private field from wm_coeff_ctlsound/soc/codecs/wm_adsp.c+0 -10 replies
9/13ASoC: wm_adsp: Group all the ALSA control functions togethersound/soc/codecs/wm_adsp.c+140 -1400 replies
10/13ASoC: wm_adsp: Add basic support for rev 1 firmware file formatsound/soc/codecs/wm_adsp.c sound/soc/codecs/wm_adsp.h sound/soc/codecs/wmfw.h+226 -491 reply
11/13ASoC: wm_adsp: Add support for DSP control flagssound/soc/codecs/wm_adsp.c sound/soc/codecs/wmfw.h+37 -82 replies
12/13ASoC: wm_adsp: Add support for rev 2 firmware file formatsound/soc/codecs/wm_adsp.c+119 -181 reply
13/13ASoC: wm_adsp: Warn that firmware file format 0 is depreciatedsound/soc/codecs/wm_adsp.c+3 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] ADSP Firmware Controls Update

This series of patches starts with a few small clean ups for the ADSP code, and then finally adds support for the rev 1 and 2 firmware file formats. The revision 1 format is in common usage in the field so it is long overdue to get support for that merged to mainline. The revision 2 format is fairly new but is starting to see some deployment as well.

There is still more work todo here. The main next step is to add support for arbitary length controls through the TLV binary control feature that was recently added to the kernel. This patch series will truncate any long controls to 512 bytes.

Thanks,
Charles

Charles Keepax (13):
ASoC: wm_adsp: Split out adsp1 & 2 setup algorithms
ASoC: wm_adsp: Improve variable naming
ASoC: wm_adsp: Remove len field from wm_adsp_alg_region
ASoC: wm_adsp: Limit firmware control name to ALSA control name size
ASoC: wm_adsp: Move temporary control name to the stack
ASoC: wm_adsp: Clean up low level control read/write functions
ASoC: wm_adsp: Factor out creation of alg_regions
ASoC: wm_adsp: Remove private field from wm_coeff_ctl
ASoC: wm_adsp: Group all the ALSA control functions together
ASoC: wm_adsp: Add basic support for rev 1 firmware file format
ASoC: wm_adsp: Add support for DSP control flags
ASoC: wm_adsp: Add support for rev 2 firmware file format
ASoC: wm_adsp: Warn that firmware file format 0 is depreciated

 sound/soc/codecs/wm_adsp.c | 1129 +++++++++++++++++++++++++++-----------------
 sound/soc/codecs/wm_adsp.h |    6 +-
 sound/soc/codecs/wmfw.h    |   44 ++-
 3 files changed, 733 insertions(+), 446 deletions(-)
Signature · 1 line
1.7.2.5