Skip to content

RFC perf tools: Report event parsing errors

Jiri Olsa lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6perf tools: Add parse_events_error interfacetools/perf/builtin-stat.c tools/perf/tests/code-reading.c tools/perf/tests/evsel-roundtrip-name.c +11 more+116 -320 replies
2/6perf tools: Add flex support for parse_events_errortools/perf/util/parse-events.h tools/perf/util/parse-events.l tools/perf/util/parse-events.y+37 -80 replies
3/6perf tools: Change parse_events_add_pmu interfacetools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.y+12 -100 replies
4/6perf tools: Add location to pmu event termstools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.y+35 -190 replies
5/6perf tools: Add term support for parse_events_errortools/perf/tests/pmu.c tools/perf/util/parse-events.c tools/perf/util/pmu.c +1 more+23 -100 replies
6/6perf tools: Add tracepoint support for parse_events_errortools/perf/util/parse-events.y+7 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/6] perf tools: Report event parsing errors

hi,
adding support to report error from event string parsing.

This patchset contains support for standard parsing errors and more logic to recognize tracepoint and 'pmu//' terms, like:

  $ perf record -e 'sched:krava' ls
  invalid or unsupported event: 'sched:krava'
                                 \___ unknown tracepoint
  $ ./perf record -e 'cpu/even=0x1/' ls
  invalid or unsupported event: 'cpu/even=0x1/'
                                     \___ unknown term
  $ perf record -e cycles,cache-mises ls
  invalid or unsupported event: '..es,cache-mises'
                                           \___ parser error

any feedback about the error string shape would be great ;-)

Changes are also reachable in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/event_parse_error

thanks
jirka

---
Jiri Olsa (6):
perf tools: Add parse_events_error interface perf tools: Add flex support for parse_events_error perf tools: Change parse_events_add_pmu interface perf tools: Add location to pmu event terms perf tools: Add term support for parse_events_error perf tools: Add tracepoint support for parse_events_error

 tools/perf/builtin-stat.c               |   2 +-
 tools/perf/tests/code-reading.c         |   2 +-
 tools/perf/tests/evsel-roundtrip-name.c |   4 +--
 tools/perf/tests/hists_cumulate.c       |   2 +-
 tools/perf/tests/hists_filter.c         |   4 +--
 tools/perf/tests/hists_link.c           |   4 +--
 tools/perf/tests/hists_output.c         |   2 +-
 tools/perf/tests/keep-tracking.c        |   4 +--
 tools/perf/tests/parse-events.c         |   2 +-
 tools/perf/tests/perf-time-to-tsc.c     |   2 +-
 tools/perf/tests/pmu.c                  |   2 +-
 tools/perf/tests/switch-tracking.c      |   8 +++---
 tools/perf/util/parse-events.c          | 135 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------
 tools/perf/util/parse-events.h          |  32 ++++++++++++++--------
 tools/perf/util/parse-events.l          |  37 ++++++++++++++++++++++---
 tools/perf/util/parse-events.y          |  35 ++++++++++++++----------
 tools/perf/util/pmu.c                   |  23 +++++++++++-----
 tools/perf/util/pmu.h                   |   6 +++--
 tools/perf/util/record.c                |   4 +--
 19 files changed, 230 insertions(+), 80 deletions(-)