Skip to content

RFC tc cleanup?

Alexei Starovoitov netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tc: fix return values of ingress qdiscnet/core/dev.c net/sched/sch_ingress.c+6 -114 replies
2/3tc: deprecate TC_ACT_QUEUEDinclude/uapi/linux/pkt_cls.h net/sched/sch_api.c net/sched/sch_atm.c +13 more+3 -1518 replies
3/3tc: cleanup tc_classifyinclude/net/pkt_sched.h include/net/sch_generic.h net/sched/sch_api.c +6 more+52 -904 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/3] tc cleanup?

Hi,

I've started cleaning TC a bit.
Before I go too far, need your feedback on this RFC:

patch 1 - stop abuse of return values in ingress qdisc patch 2 - deprecate TC_ACT_QUEUED
patch 3 - reduce copy-paste around tc_classify()

Lightly tested so far. Waiting for John's and other tc test scripts.

Alexei Starovoitov (3):
tc: fix return values of ingress qdisc
tc: deprecate TC_ACT_QUEUED
tc: cleanup tc_classify

 include/net/pkt_sched.h      |    2 ++
 include/net/sch_generic.h    |    7 +++++++
 include/uapi/linux/pkt_cls.h |    2 +-
 net/core/dev.c               |    8 ++------
 net/sched/sch_api.c          |   22 ++++++++++++++++++++++
 net/sched/sch_atm.c          |    1 -
 net/sched/sch_cbq.c          |    1 -
 net/sched/sch_choke.c        |   17 +++--------------
 net/sched/sch_drr.c          |   18 +++---------------
 net/sched/sch_dsmark.c       |    1 -
 net/sched/sch_fq_codel.c     |   25 ++++++-------------------
 net/sched/sch_hfsc.c         |    1 -
 net/sched/sch_htb.c          |    1 -
 net/sched/sch_ingress.c      |   10 ++++------
 net/sched/sch_multiq.c       |    1 -
 net/sched/sch_prio.c         |    1 -
 net/sched/sch_qfq.c          |   16 ++--------------
 net/sched/sch_sfb.c          |   17 +++--------------
 net/sched/sch_sfq.c          |   26 ++++++--------------------
 19 files changed, 61 insertions(+), 116 deletions(-)
Signature · 1 line
1.7.9.5