RFC reduce header dependency on rte_mbuf.h
Status from this message: Applied, thanks
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest8 patches 2 repliesApplied
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | distributor: remove header inclusion of mbuf.happ/ app/ lib/ | +6 | 0 replies | |
| 2/8 | ethdev: remove inclusion of rte_mbuf.hlib/ | +2 | 0 replies | |
| 3/8 | kni: remove header inclusion of rte_mbuf.hlib/ | +1 | 0 replies | |
| 4/8 | ip_frag: remove header inclusion of rte_mbuf.hlib/ | +2 | 0 replies | |
| 5/8 | pipeline: remove header inclusion of rte_mbuf.hlib/ | +2 | 0 replies | |
| 6/8 | virtio: remove header inclusion of rte_mbuf.hlib/ lib/ | +4 | 0 replies | |
| 7/8 | table: remove header inclusion of rte_mbuf.hlib/ | +2 | 0 replies | |
| 8/8 | vhost: remove header inclusion of rte_mbuf.hlib/ | +2 | 0 replies |
Reviews trailers per patch
None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Olivier Matz |
|---|---|
| Series | A-b |
| 1/8 | |
| 2/8 | |
| 3/8 | |
| 4/8 | |
| 5/8 | |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/8] reduce header dependency on rte_mbuf.h
A large number of our header files and libraries are dependent on one another, which can lead to problems with circular dependencies if trying to tie some of those libraries together, e.g. when prototyping with pktdev, or other schemes to get a common API for ethdev/rings/KNI. :-)
One small way to reduce issues when doing this is to eliminate #includes when they are not needed. While most includes in our headers are necessary, one common pattern seen is where a library just takes mbufs as part of it's API, but does not de-reference those in the header file. In cases like this, it's not necessary to include the whole mbuf header file just to allow pointers to mbuf structures - a forward declaration of "struct rte_mbuf" will do. Including the mbuf header file, also triggers inclusion of the mempool headers which causes the inclusion of the ring headers amongst others.
Therefore, I propose changing the header files for our libraries to just use the forward declaration instead of the full header inclusion where possible.
Bruce Richardson (8):
distributor: remove header inclusion of mbuf.h
ethdev: remove inclusion of rte_mbuf.h
kni: remove header inclusion of rte_mbuf.h
ip_frag: remove header inclusion of rte_mbuf.h
pipeline: remove header inclusion of rte_mbuf.h
virtio: remove header inclusion of rte_mbuf.h
table: remove header inclusion of rte_mbuf.h
vhost: remove header inclusion of rte_mbuf.h
app/test/test_distributor.c | 2 ++ app/test/test_distributor_perf.c | 3 +++ lib/librte_distributor/rte_distributor.h | 3 +-- lib/librte_ether/rte_ethdev.h | 3 ++- lib/librte_ip_frag/rte_ip_frag.h | 3 ++- lib/librte_kni/rte_kni.h | 2 +- lib/librte_pipeline/rte_pipeline.h | 3 ++- lib/librte_pmd_virtio/virtqueue.h | 3 ++- lib/librte_pmd_xenvirt/virtqueue.h | 3 ++- lib/librte_table/rte_table.h | 3 ++- lib/librte_vhost/rte_virtio_net.h | 3 ++- 11 files changed, 21 insertions(+), 10 deletions(-)
Signature · 1 line
2.1.0