Skip to content

hw/ppc/spapr: Improve error printing

Thomas Huth qemu-devel 1 version Applied

Status from this message: Thanks, applied to spapr-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2hw/ppc/spapr: Fix error message when firmware could not be loadedhw/ppc/spapr.c+3 -30 replies
2/2hw/ppc/spapr: Use error_report() instead of hw_error()hw/ppc/spapr.c+6 -63 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] hw/ppc/spapr: Improve error printing

While loading alternate slof.bin images with the "-bios" option of qemu-softmmu-ppc64, I noticed that the error message is wrong when trying to load an non-existing file. Also, the error message is printed with hw_error() which results in a huge CPU register dump - something you don't expect when you just typed in a wrong filename, and is rather confusing here since you've got to find the real error message in the huge output first. So let's fix that, too.

Thomas Huth (2):
ppc/spapr: Fix error message when firmware could not be loaded hw/ppc/spapr: Use error_report() instead of hw_error()

 hw/ppc/spapr.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
Signature · 1 line
1.8.3.1