Fix implicit includes of <module.h> that will break.
Status from this message: Applied, thanks Paul.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | drivers/crypto: include <module.h> for modular caam codedrivers/ | +1 | 2 replies | |
| 2/11 | drivers/clk: include <module.h> for clk-max77xxx modular codedrivers/ drivers/ | +2 | 2 replies | |
| 3/11 | drivers/gpio: include <module.h> for modular crystalcove codedrivers/ | +1 | 1 reply | |
| 4/11 | drivers/gpu: include <module.h> for modular rockchip codedrivers/ drivers/ | +2 | 0 replies | |
| 5/11 | drivers/hsi: include <module.h> for modular omap_ssi codedrivers/ | +1 | 0 replies | |
| 6/11 | drivers/net: include <module.h> for modular stmmac_platform codedrivers/ | +1 | 1 reply | |
| 7/11 | drivers/pcmcia: include <module.h> for modular xxs1500_ss codedrivers/ | +1 | 1 reply | |
| 8/11 | drivers/pcmcia: include <module.h> for modular max77802 codedrivers/ | +1 | 3 replies | |
| 9/11 | drivers/scsi: include <module.h> for modular ufshcd-pltfrm codedrivers/ | +1 | 3 replies | |
| 10/11 | drivers/staging: include <module.h> for modular android tegra_ion codedrivers/ | +1 | 0 replies | |
| 11/11 | sh: mach-highlander/psw.c is tristate and should use module.harch/ | +1 | 0 replies |
Reviews trailers per patch
2 of 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Stephen Boyd | Wolfram Sang | Krzysztof Kozlowski | Viresh Kumar |
|---|---|---|---|---|
| Series | A-b | A-b | ||
| 1/11 | ||||
| 2/11 | A-b | |||
| 3/11 | ||||
| 4/11 | ||||
| 5/11 | ||||
| 6/11 | ||||
| 7/11 | A-b | |||
| 8/11 | ||||
| 9/11 | ||||
| 10/11 | ||||
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 00/11] Fix implicit includes of <module.h> that will break.
The files changed here are simply modular source files that are implicitly relying on <module.h> being present. We fix them up now, so that we can decouple some of the module related init code from the core init code in another pending series.
This is the second series; a pseudo followup to the 1st series[1] factored out from what was a previously larger series[2] so that there is a common theme and lower patch count to ease review.
In this case the addition of module.h include to several files is the common theme, and it is a no-op from a code generation point of view, and even from a compile point of view at this point in time.
There are probably lots more implicit includes of <module.h> in tree, but these are the ones that must be fixed in order to avoid build breakage fallout for the pending module.h <---> init.h code relocations.
Paul.
[1] https://lkml.org/lkml/2015/4/27/777
[2] https://marc.info/?l=linux-kernel&m=139033951228828
---
Paul Gortmaker (11):
drivers/crypto: include <module.h> for modular caam code drivers/clk: include <module.h> for clk-max77xxx modular code drivers/gpio: include <module.h> for modular crystalcove code drivers/gpu: include <module.h> for modular rockchip code drivers/hsi: include <module.h> for modular omap_ssi code drivers/net: include <module.h> for modular stmmac_platform code drivers/pcmcia: include <module.h> for modular xxs1500_ss code drivers/pcmcia: include <module.h> for modular max77802 code drivers/scsi: include <module.h> for modular ufshcd-pltfrm code drivers/staging: include <module.h> for modular android tegra_ion code
sh: mach-highlander/psw.c is tristate and should use module.h
arch/sh/boards/mach-highlander/psw.c | 2 +- drivers/clk/clk-max77686.c | 1 + drivers/clk/clk-max77802.c | 1 + drivers/crypto/caam/ctrl.c | 1 + drivers/gpio/gpio-crystalcove.c | 1 + drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 + drivers/hsi/controllers/omap_ssi.h | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 + drivers/pcmcia/xxs1500_ss.c | 1 + drivers/regulator/max77802.c | 1 + drivers/scsi/ufs/ufshcd-pltfrm.c | 1 + drivers/staging/android/ion/tegra/tegra_ion.c | 1 + 13 files changed, 13 insertions(+), 1 deletion(-)
Signature · 1 line
2.2.1