RFC atp870u: Remove the first level of crap
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest34 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/34 | atp870u: Remove workportdrivers/ | +28 | 0 replies | |
| 2/34 | atp870u: Remove tmport1drivers/ | +3 | 0 replies | |
| 3/34 | atp870u: Untangle tmportdrivers/ | +71 | 0 replies | |
| 4/34 | atp870u: Untangle tmport #2drivers/ | +32 | 0 replies | |
| 5/34 | atp870u: Untangle tmport #3drivers/ | +49 | 0 replies | |
| 6/34 | atp870u: Untangle tmport #4drivers/ | +138 | 0 replies | |
| 7/34 | atp870u: Untangle tmport #5drivers/ | +173 | 0 replies | |
| 8/34 | atp870u: Untangle tmport #6drivers/ | +49 | 0 replies | |
| 9/34 | atp870u: Untangle tmport #7drivers/ | +5 | 0 replies | |
| 10/34 | atp870u: Untangle tmport #8drivers/ | +177 | 0 replies | |
| 11/34 | atp870u: Untangle tmpcipdrivers/ | +23 | 0 replies | |
| 12/34 | atp870u: Untangle tmpcip #2drivers/ | +9 | 0 replies | |
| 13/34 | atp870u: Remove ugly gotosdrivers/ | +30 | 0 replies | |
| 14/34 | atp870u: Remove ugly gotos #2drivers/ | +30 | 0 replies | |
| 15/34 | atp870u: Remove ugly gotos #3drivers/ | +6 | 0 replies | |
| 16/34 | atp870u: Remove ugly gotos #4drivers/ | +15 | 0 replies | |
| 17/34 | atp870u: Remove ugly gotos #5drivers/ | +62 | 0 replies | |
| 18/34 | atp870u: Introduce HW access wrappersdrivers/ | +252 | 0 replies | |
| 19/34 | atp870u: Convert is870() to use wrappersdrivers/ | +138 | 0 replies | |
| 20/34 | atp870u: Convert is880() to use wrappersdrivers/ | +176 | 0 replies | |
| 21/34 | atp870u: Convert is885() to use wrappersdrivers/ | +179 | 0 replies | |
| 22/34 | atp870u: Unify code format in is870(), is880() and is885()drivers/ | +101 | 0 replies | |
| 23/34 | atp870u: Add channel parameter to is870() and is880()drivers/ | +342 | 0 replies | |
| 24/34 | atp870u: Move chip-specific lines out of is880() and is885()drivers/ | +10 | 0 replies | |
| 25/34 | atp870u: Remove is880()drivers/ | +1 | 0 replies | |
| 26/34 | atp870u: Add wide_chip parameter to is870() and is885()drivers/ | +25 | 0 replies | |
| 27/34 | atp870u: Add remaining 870 support to is885()drivers/ | +31 | 0 replies | |
| 28/34 | atp870u: Move 870-specific code out of is870()drivers/ | +2 | 0 replies | |
| 29/34 | atp870u: Remove is870()drivers/ | +1 | 0 replies | |
| 30/34 | atp870u: Rename is885() to atp_is()drivers/ | +6 | 0 replies | |
| 31/34 | atp870u: Convert remaining in[bwl] and out[bwl] to wrappersdrivers/ | +118 | 0 replies | |
| 32/34 | atp870u: Replace port 0x80 delay by udelaydrivers/ | +9 | 0 replies | |
| 33/34 | atp870u: Fix incorrect writeb_io access to register 0x3adrivers/ | +4 | 0 replies | |
| 34/34 | atp870u: Introduce atp_set_host_iddrivers/ | +18 | 0 replies |
Reviews trailers per patch
None of the 34 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Christoph Hellwig |
|---|---|
| Series | A-b |
| 1/34 | |
| 2/34 | |
| 3/34 | |
| 4/34 | |
| 5/34 | |
| 6/34 | |
| 7/34 | |
| 8/34 | |
| 9/34 | |
| 10/34 | |
| 11/34 | |
| 12/34 | |
| 13/34 | |
| 14/34 | |
| 15/34 | |
| 16/34 | |
| 17/34 | |
| 18/34 | |
| 19/34 | |
| 20/34 | |
| 21/34 | |
| 22/34 | |
| 23/34 | |
| 24/34 | |
| 25/34 | |
| 26/34 | |
| 27/34 | |
| 28/34 | |
| 29/34 | |
| 30/34 | |
| 31/34 | |
| 32/34 | |
| 33/34 | |
| 34/34 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 00/34] atp870u: Remove the first level of crap
This patch series removes the first level of crap from atp870u - the worst (in-tree) SCSI driver [1], allowing some more work to be done next.
First the driver is converted to C from something that looks like a (bad) assembler code: use of tmport for all I/O accesses and gotos all over the code.
Then I/O access wrappers are introduced.
Finally, is870, is880 and is885 are unified and two of them removed.
Tested on AEC-6710D (ATP870IU-C).
[1] http://www.spinics.net/lists/linux-scsi/msg81142.html
atp870u.c | 3226 ++++++++++++++++---------------------------------------------- 1 file changed, 880 insertions(+), 2346 deletions(-)
Signature · 1 line
Ondrej Zary