Skip to content

percpu_counter: xfs requires custom compare batch size

Dave Chinner linux-xfs lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v12 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2percpu_counter: batch size aware __percpu_counter_compare()include/linux/percpu_counter.h lib/percpu_counter.c+15 -43 replies
2/2xfs: inode and free block counters need to use __percpu_counter_comparefs/xfs/xfs_mount.c+20 -141 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBrian FosterTejun Heo
1/2A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/2 v2] percpu_counter: xfs requires custom compare batch size

Hi folks,

This is v2 of the regression fix for the new generic per-cpu superblock counter code in XFS. The problems fixed arise from using custom batch sizes for addition and decrement exceeding the "accurate compare" bounds in percpu_counter_compare() and hence resulting in incorrect comparisons being made.

This regression was introduced in 4.1-rc1 and it requires a small tweak to the percpu counter infrastructure to fix, hence the two patches.

Comments welcome!

-Dave.