Skip to content

Make kms_fbc_crc useful again

Paulo Zanoni intel-gfx 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tests/kms_fbc_crc: exec_nop() can also invalidate FBCtests/kms_fbc_crc.c+1 -00 replies
2/8tests/kms_fbc_crc: increase the FBC wait timeouttests/kms_fbc_crc.c+1 -10 replies
3/8tests/kms_fbc_crc: unify flip handlingtests/kms_fbc_crc.c+3 -40 replies
4/8tests/kms_fbc_crc: refactor context handling codetests/kms_fbc_crc.c+5 -50 replies
5/8tests/kms_fbc_crc: extract check_crc()tests/kms_fbc_crc.c+14 -120 replies
6/8tests/kms_fbc_crc: make the blt test draw the same patterntests/kms_fbc_crc.c+3 -20 replies
7/8tests/kms_fbc_crc: extract fill_mmap_{cpu, gtt}()tests/kms_fbc_crc.c+25 -100 replies
8/8tests/kms_fb_crc: fix the reference CRC checkingtests/kms_fbc_crc.c+82 -350 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH igt 0/8] Make kms_fbc_crc useful again

From: Paulo Zanoni <[email protected]>

After the recent IGT regressions and the FBC conversion to the frontbuffer tracking infrastructure, kms_fbc_crc was not being that useful anymore. So this series makes it useful again.

The first 2 patches are alternate forms of patches that I already sent to the mailing list a few times. They are needed due to the Kernel FBC changes. In the previous versions I was adding gem_sync() calls, but now I'm just increasing the timeouts. I'm aware we want to have test cases for both situations, but for now let's fix the ones we already have with the least intrusive solution.

The other 6 patches are just for the CRC regression fix. Notice that kms_fbc_crc is completely useless without this fix. Daniel has already sent an earlier for this problem, but I believe my proposed solution is more complete.

Of course, to make kms_fbc_crc actually useful we need to enable FBC by default again, but we're not there yet.

Also notice that there's still no conversion to use lib/igt_draw, but some of the reworks required by it are already on this series. I want to land any possible conversion only after we fix the current known regressions.

Thanks,
Paulo

Paulo Zanoni (8):
tests/kms_fbc_crc: exec_nop() can also invalidate FBC tests/kms_fbc_crc: increase the FBC wait timeout tests/kms_fbc_crc: unify flip handling tests/kms_fbc_crc: refactor context handling code tests/kms_fbc_crc: extract check_crc() tests/kms_fbc_crc: make the blt test draw the same pattern tests/kms_fbc_crc: extract fill_mmap_{cpu,gtt}() tests/kms_fb_crc: fix the reference CRC checking

 tests/kms_fbc_crc.c | 193 +++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 129 insertions(+), 64 deletions(-)
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx