Introduce BIT and GENMASK
Get series with b4
b4 am CAD6G_RTOuw_JtHe5kPSPYh1D07E9SGYLgRd-miS64+4SpvK6Nw@mail.gmail.comVersions newest first · linked by author and title
- v2 Latest posting 3/30 of 5 patches 0 repliesNew
- v2 posting 2/30 of 5 patches 0 repliesSuperseded
- v2 posting 1/35 patches 0 repliesSuperseded
Patches in v2 posting 3/3 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [U-Boot] [PATCH v2 0/5] Introduce BIT and GENMASK
Quoted 31 lines · Simon Glass
Hi,
Quoted 28 lines · Marek Vasut
Quoted 27 lines · Tom Rini
Quoted 25 lines · Marek Vasut
Quoted 20 lines · Jagan Teki
Quoted 12 lines · Jagan Teki
I have sent one v1 for BIT macro change for entire u-boot, but this time I'm just introduce by changing this with spi/sf code, will send more in changes in future.
Along with BIT and also introduces GENMASK with spi/sf code.
Changes for v2:
- break the BIT macro patch only for spi/sf code.thanks!
Jagan.Quoted 6 lines
Jagan Teki (5):
spi/sf: Add BIT macro inlinux/bitops.h
spi: Remove #define BIT in local file
spi/sf: Use BIT macro fromlinux/bitops.h
linux/bitops.h: GENMASK copy from linux
spi: Use GENMASK instead of numeric hexcodesQuoted 2 lines
Any comments on this series - early push will have enough time to test and I have more patches that need to use these macros.
I'm not very fond of this macro, it makes the code more cryptic .
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
BIT/GENMASK are (growing in usage) kernel macros, so I think it'll help us in the long run.
I won't block this, but I'm not very fond of such cryptic stuff.
Not thrilled either, but I agree it makes sense to follow kernel practice here as elsewhere.
OK, then I will push these changes and probably start more updates on remaining code as well.
Any comments/reviews - pleas share.
thanks!
Signature · 2 lines
Jagan Teki, Openedev.