Skip to content

generic: fixes for different allocation behaviours

Dave Chinner fstests 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3generic/018: use xfs_io and larger buffers for writestests/generic/018+12 -70 replies
2/3generic/223, xfs/203: IO is not well alignedtests/generic/223 tests/xfs/203+3 -30 replies
3/3generic/275: writes may not partially succeedtests/generic/275+7 -30 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBrian Foster
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] generic: fixes for different allocation behaviours

Hi folks,

These 3 patches address failures I found when testing the XFS DAX functionality. DAX disables delayed allocation on XFS, so the size of the buffer in the write() call determines the size of the allocation that is done. Hence tests that expect a specific extent layout need to do IO in buffers as large as the extent size they expect to be created.

The other side of this is that some tests also expect partial writes to occur, which happened as a side effect of buffered writes being broken down into PAGE_SIZE chunks. With DAX, that does not happen - the writes tend to either succeed or fail completely, especially if it is an ENOSPC condition that is ocurring.

HEnce these patches address these test assumptions, and now they work correctly and pass on both DAX and non-DAX filesystems.

Cheers,

Dave.