fdc: Clean up and fix command processing
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 16 repliesIn review
- v18 patches 31 repliesSuperseded
Changes in v2 from the cover letter
- Patch 3: Include fdctrl->phase in the migration state. [Peter]
- Patch 4: Added a comment to clarify an assertion [Peter]
- Patch 5: Check pos == 0 instead of fdctrl->data_pos == 1 [John]
- Patch 7: Improved commit message [John]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | fdc: Rename fdctrl_reset_fifo() to fdctrl_to_command_phase()hw/ | +15 | 0 replies | |
| 2/8 | fdc: Rename fdctrl_set_fifo() to fdctrl_to_result_phase()hw/ | +16 | 0 replies | |
| 3/8 | fdc: Introduce fdctrl->phasehw/ | +89 | 13 replies | |
| 4/8 | fdc: Use phase in fdctrl_write_data()hw/ | +41 | 0 replies | |
| 5/8 | fdc: Code cleanup in fdctrl_write_data()hw/ | +39 | 1 reply | |
| 6/8 | fdc: Disentangle phases in fdctrl_read_data()hw/ | +23 | 0 replies | |
| 7/8 | fdc: Fix MSR.RQM flaghw/ | +12 | 1 reply | |
| 8/8 | fdc-test: Test state for existing cases more thoroughlytests/ | +34 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | John Snow |
|---|---|
| 1/8 | R-b |
| 2/8 | R-b |
| 3/8 | A-b |
| 4/8 | R-b |
| 5/8 | R-b |
| 6/8 | R-b |
| 7/8 | R-b |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/8] fdc: Clean up and fix command processing
The hotfix for CVE-2015-3456 fixed the security problem, but didn't fully correct the behaviour of the emulated floppy controller. This series fixes the bug that was the root cause for the problem, and does some cleanup in the FIFO access functions to make the command processing more obvious.
v2:
- Patch 3: Include fdctrl->phase in the migration state. [Peter]
- Patch 4: Added a comment to clarify an assertion [Peter]
- Patch 5: Check pos == 0 instead of fdctrl->data_pos == 1 [John]
- Patch 7: Improved commit message [John]
FWIW, when testing this, I found that migration with active I/O on a floppy drive doesn't work very reliably. These problems were there before the series and they stay after the series. I verified as good as I could that the subsection magic does its job, and I'll leave fixing the other floppy migration bugs for someone else.
Kevin Wolf (8):
fdc: Rename fdctrl_reset_fifo() to fdctrl_to_command_phase()
fdc: Rename fdctrl_set_fifo() to fdctrl_to_result_phase()
fdc: Introduce fdctrl->phase
fdc: Use phase in fdctrl_write_data()
fdc: Code cleanup in fdctrl_write_data()
fdc: Disentangle phases in fdctrl_read_data()
fdc: Fix MSR.RQM flag
fdc-test: Test state for existing cases more thoroughly
hw/block/fdc.c | 296 ++++++++++++++++++++++++++++++++++++++++--------------- tests/fdc-test.c | 34 +++++++ 2 files changed, 253 insertions(+), 77 deletions(-)
Signature · 1 line
1.8.3.1