Skip to content

Fix an issue with 'ethtool' configuring PHYs

Arun Parameswaran lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1net: core: 'ethtool' issue with querying phy settingsnet/core/ethtool.c+9 -19 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchRay JuiScott Branden
1/1R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] Fix an issue with 'ethtool' configuring PHYs

Hi,

This patch fixes an issue while using the 'ethtool' to query/set PHY's configurations. The 'ethtool' interface in the Kernel seem to always query settings for PHY0, irrespective of the PHY specified, while issuing the 'ethtool' command.

For example when issueing 'ethtool -s eth0 phyad 1 speed 100' command to set the speed of PHY1's speed, the current software would first retrieve PHY0 settings, then apply the request settings (in this case 'speed') on top. It then uses this (PHY0's config with new speed) settings to update the PHY1, which now ends up with partial configurations of PHY0 and the new speed.

This patch series is based on Linux v4.1-rc4 and is available in:
https://github.com/Broadcom/cygnus-linux/tree/net-core-ethtool-fix-v1

Arun Parameswaran (1):
SWMAPYVR-4339 net: core: 'ethtool' issue with querying phy settings

 net/core/ethtool.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5