monitor: Wean core off QError, and other cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest21 patches 6 repliesIn review
- v220 patches 8 repliesSuperseded
- v120 patches 35 repliesSuperseded
Changes in v3 from the cover letter
* Trivially rebased, R-bys retained.
* PATCH 11: New [Luiz]
Patches in v3 No applies recorded yet
Reviews trailers per patch
All 21 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Luiz Capitulino |
|---|---|---|
| 1/21 | R-b | R-b |
| 2/21 | R-b | R-b |
| 3/21 | R-b | R-b |
| 4/21 | R-b | R-b |
| 5/21 | R-b | R-b |
| 6/21 | R-b | R-b |
| 7/21 | R-b | R-b |
| 8/21 | R-b | R-b |
| 9/21 | R-b | R-b |
| 10/21 | R-b | R-b |
| 11/21 | R-b | R-b |
| 12/21 | R-b | R-b |
| 13/21 | R-b | R-b |
| 14/21 | R-b | R-b R-b |
| 15/21 | R-b | R-b |
| 16/21 | R-b | R-b |
| 17/21 | R-b | R-b |
| 18/21 | R-b | R-b |
| 19/21 | R-b | R-b |
| 20/21 | R-b | R-b |
| 21/21 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 00/21] monitor: Wean core off QError, and other cleanups
Command handlers still use QError. Left for another day.
v3:
* Trivially rebased, R-bys retained.
* PATCH 11: New [Luiz]
v2:
* Trivially rebased, R-bys retained.
* PATCH 01: Drop another async remnant [Eric]
* PATCH 01+02+18: Improve commit messages
* PATCH 03+04: client_migrate_info still hasn't been implemented VNC, de-document [Eric, Gerd]
* PATCH 16+19: Don't inline monitor_ctrl_mode() into monitor_init() [Eric]
* PATCH 20: Use false instead of 0 [Eric]
Markus Armbruster (21):
monitor: Drop broken, unused asynchronous command interface
monitor: Clean up after previous commit
monitor: Improve and document client_migrate_info protocol error
monitor: Convert client_migrate_info to QAPI
monitor: Use traditional command interface for HMP drive_del
monitor: Use traditional command interface for HMP device_add
monitor: Use trad. command interface for HMP pcie_aer_inject_error
monitor: Drop unused "new" HMP command interface
monitor: Propagate errors through qmp_check_client_args()
monitor: Propagate errors through qmp_check_input_obj()
monitor: Propagate errors through invalid_qmp_mode()
monitor: Wean monitor_protocol_emitter() off mon->error
monitor: Inline monitor_has_error() into its only caller
monitor: Limit QError use to command handlers
monitor: Rename handle_user_command() to handle_hmp_command()
monitor: Rename monitor_control_read(), monitor_control_event()
monitor: Unbox Monitor member mc and rename to qmp
monitor: Drop do_qmp_capabilities()'s superfluous QMP check
monitor: Turn int command_mode into bool in_command_mode
monitor: Rename monitor_ctrl_mode() to monitor_is_qmp()
monitor: Change return type of monitor_cur_is_qmp() to bool
blockdev.c | 9 +- hmp-commands.hx | 20 +-- hmp.c | 23 +++ hmp.h | 2 + hw/pci/pci-stub.c | 14 +- hw/pci/pcie_aer.c | 39 +++-- include/monitor/monitor.h | 7 +- include/sysemu/blockdev.h | 2 +- include/sysemu/sysemu.h | 4 +- monitor.c | 398 ++++++++++++++++------------------------------ qapi-schema.json | 19 +++ qmp-commands.hx | 16 +- stubs/mon-is-qmp.c | 4 +- 13 files changed, 232 insertions(+), 325 deletions(-)
Signature · 1 line
1.9.3