Skip to content

SkystarS2 pid filtering fix and stream control

Jemma Denson linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v14 patches 5 repliesSuperseded

Changes in v2 from the cover letter

* Move the stream reset code from flexcop_pci to flexcop_hw_filter so the fact it might interfere with hw_filter code isn't missed.
* Control both streams - so output stream aswell as receive.
* Track the external stream state so we don't leave the stream turned off in a reset.
* Don't let the external control start the stream until a feed is actually requested.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4b2c2: Add option to skip the first 6 pid filtersdrivers/media/common/b2c2/flexcop-common.h drivers/media/common/b2c2/flexcop-fe-tuner.c drivers/media/common/b2c2/flexcop-hw-filter.c+18 -23 replies
2/4b2c2: Move stream reset code from flexcop-pci to flexcopdrivers/media/common/b2c2/flexcop-common.h drivers/media/common/b2c2/flexcop-hw-filter.c drivers/media/pci/b2c2/flexcop-pci.c+18 -140 replies
3/4b2c2: Add external stream controldrivers/media/common/b2c2/flexcop-common.h drivers/media/common/b2c2/flexcop-hw-filter.c drivers/media/pci/b2c2/flexcop-pci.c+36 -100 replies
4/4cx24120: Take control of b2c2 streamsdrivers/media/common/b2c2/flexcop-fe-tuner.c drivers/media/dvb-frontends/cx24120.c drivers/media/dvb-frontends/cx24120.h+31 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] SkystarS2 pid filtering fix and stream control

This patch series finishes off the addition of the SkyStarS2 card - the patches here aren't strictly required for running the card so haven't previously been included.

The first patch fixes a bug present in the current flexcop driver - I've seen it with this card, and it has also been noticed in some other cards. Those cards will need identifying and patches created to use this fix as it is not enabled by default.

The other three patches add in a feature that was half complete in the original binary blob for this card, and allows the demod chip to control the streams on the b2c2 when it turns off it's output during tuning. This helps to avoid a situation where the hardware filter is constantly reset by a software watchdog in flexcop-pci because it can't see any data coming in.

Changes since v1:
* Move the stream reset code from flexcop_pci to flexcop_hw_filter so the fact it might interfere with hw_filter code isn't missed.
* Control both streams - so output stream aswell as receive.
* Track the external stream state so we don't leave the stream turned off in a reset.
* Don't let the external control start the stream until a feed is actually requested.

Jemma Denson (4):
b2c2: Add option to skip the first 6 pid filters
b2c2: Move stream reset code from flexcop-pci to flexcop
b2c2: Add external stream control
cx24120: Take control of b2c2 streams

 drivers/media/common/b2c2/flexcop-common.h    |  5 ++
 drivers/media/common/b2c2/flexcop-fe-tuner.c  | 13 +++++
 drivers/media/common/b2c2/flexcop-hw-filter.c | 71 ++++++++++++++++++++++-----
 drivers/media/dvb-frontends/cx24120.c         | 29 +++++++----
 drivers/media/dvb-frontends/cx24120.h         |  1 +
 drivers/media/pci/b2c2/flexcop-pci.c          | 19 ++-----
 6 files changed, 103 insertions(+), 35 deletions(-)
Signature · 1 line
2.1.0