Fix couple of issues with 'ethtool' get/set API's
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ethtool: Clear the command data structure before sending requestsethtool.c | +3 | 0 replies | |
| 2/2 | ethtool: Fix an issue with handling 'phyad' while updating settingsethtool.c | +6 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | JD (Jiandong) Zheng |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's
Hi,
The patch fixes 2 issues with 'ethtool' getting/setting parametres in the do_gset() do_sset() API's.
I have pushed a patch to the Kernel to fix an issue in the handling of the 'ethtool' commands which got accepted.
This Kernel patch was based on Linux v4.1-rc4 and is available in:
https://github.com/Broadcom/cygnus-linux/tree/net-core-ethtool-fix-v1
The Kernel was always clearing the command from the 'ethtool' resulting in all operations to deal with PHY0. This prevents querying/setting PHY 1's settings.
The first patch is required due to the fact that Kernel will not be clearing the command data structure. Without this the query will fail as the command will get to the Kernel with arbitary phyad info.
The second patch is to fix the issue in which the 'ethtool' gets the settings of the wrong phyad before applying the new settings.
These changes will still work with older Kernel's (as the Kernel clears the command data structure).
Thanks
Arun Parameswaran (2):
ethtool: Clear the command data structure before sending requests
ethtool: Fix an issue with handling 'phyad' while updating settings
ethtool.c | 9 +++++++++ 1 file changed, 9 insertions(+)
Signature · 1 line
1.7.9.5