Skip to content

net/dp8393x and dma/rc4030 improvements

Hervé Poussineau qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 5 repliesIn review
  2. v217 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- patch 1: keep mips jazz compilation on 64 bit big endian
- patch 14: do not use a temporary variable
- patch "net/dp8393x: repair can_receive() method" removed

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16mips jazz: compile only in 64 bitdefault-configs/mips-softmmu.mak default-configs/mips64-softmmu.mak default-configs/mips64el-softmmu.mak +4 more+4 -181 reply
2/16dma/rc4030: create custom DMA address spacehw/dma/rc4030.c+126 -370 replies
3/16dma/rc4030: use AddressSpace and address_space_rw in usershw/dma/rc4030.c hw/mips/mips_jazz.c hw/net/dp8393x.c +1 more+42 -500 replies
4/16dma/rc4030: do not use old_mmio accesseshw/dma/rc4030.c+16 -960 replies
5/16dma/rc4030: document register at offset 0x210hw/dma/rc4030.c+8 -80 replies
6/16dma/rc4030: use trace events instead of custom logginghw/dma/rc4030.c trace-events+22 -650 replies
7/16dma/rc4030: convert to QOMhw/dma/rc4030.c hw/mips/mips_jazz.c include/hw/mips/mips.h+113 -430 replies
8/16net/dp8393x: always calculate proper checksumshw/net/dp8393x.c+1 -110 replies
9/16net/dp8393x: do not use old_mmio accesseshw/net/dp8393x.c+29 -850 replies
10/16net/dp8393x: use dp8393x_ prefix for all functionshw/net/dp8393x.c+41 -390 replies
11/16net/dp8393x: QOM'ifyhw/mips/mips_jazz.c hw/net/dp8393x.c include/hw/mips/mips.h+67 -330 replies
12/16net/dp8393x: add PROM to store MAC addresshw/mips/mips_jazz.c hw/net/dp8393x.c+19 -00 replies
13/16net/dp8393x: add load/save supporthw/net/dp8393x.c+12 -00 replies
14/16net/dp8393x: correctly reset in_use fieldhw/net/dp8393x.c+1 -10 replies
15/16net/dp8393x: fix hardware resethw/net/dp8393x.c+1 -00 replies
16/16dma/rc4030: do multiple calls to address_space_rw when doing DMA transfershw/dma/rc4030.c+12 -24 replies

Reviews trailers per patch

15 of 16 patches have a Reviewed-by or Acked-by.

PatchAurelien Jarno
1/16R-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/16] net/dp8393x and dma/rc4030 improvements

Hi,

This patchset improves dp8393x network card emulation to current QEMU standards, mostly decouples it from MIPS rc4030 chipset emulation, adds PROM and load/save functionalities, and fixes some bugs seen with NetBSD.
It also converts rc4030 to QOM, and does some cleanup.

Patchset has been tested on MIPS Jazz emulation and on (yet unpublished) m68k Quadra 800 emulation.

Changes v2->v3:
- patch 1: keep mips jazz compilation on 64 bit big endian
- patch 14: do not use a temporary variable
- patch "net/dp8393x: repair can_receive() method" removed

Changes v1->v2:
- added patches 1, 5-7, 14-16
- fixed memory region life cycle in rc4030 (patch 2)
- removed a loop around address_space_rw (patch 2)
- added RFC patch 17, which highlights a bug somewhere

Hervé Poussineau (16):
mips jazz: compile only in 64 bit
dma/rc4030: create custom DMA address space
dma/rc4030: use AddressSpace and address_space_rw in users dma/rc4030: do not use old_mmio accesses
dma/rc4030: document register at offset 0x210
dma/rc4030: use trace events instead of custom logging dma/rc4030: convert to QOM
net/dp8393x: always calculate proper checksums net/dp8393x: do not use old_mmio accesses
net/dp8393x: use dp8393x_ prefix for all functions net/dp8393x: QOM'ify
net/dp8393x: add PROM to store MAC address
net/dp8393x: add load/save support
net/dp8393x: correctly reset in_use field
net/dp8393x: fix hardware reset
[RFC] dma/rc4030: do multiple calls to address_space_rw when doing DMA
transfers

 default-configs/mips-softmmu.mak     |   5 -
 default-configs/mips64-softmmu.mak   |   1 +
 default-configs/mips64el-softmmu.mak |   1 +
 default-configs/mipsel-softmmu.mak   |   5 -
 hw/dma/rc4030.c                      | 472 ++++++++++++++++++-----------------
 hw/mips/Makefile.objs                |   3 +-
 hw/mips/mips_jazz.c                  |  53 ++--
 hw/net/dp8393x.c                     | 369 ++++++++++++++-------------
 include/hw/mips/mips.h               |  11 +-
 tests/endianness-test.c              |   2 -
 trace-events                         |   6 +
 11 files changed, 477 insertions(+), 451 deletions(-)
Signature · 1 line
2.1.4