Skip to content

imx-sdma cleanup

Joshua Clayton linux-arm-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10dma: imx-sdma: constify local structsdrivers/dma/imx-sdma.c+11 -110 replies
2/10dma: imx-sdma: pass sdma engine into functionsdrivers/dma/imx-sdma.c+30 -350 replies
3/10dma: imx-sdma: use a container_of functiondrivers/dma/imx-sdma.c+15 -120 replies
4/10dma: sdma-imx set dma script address directlydrivers/dma/imx-sdma.c+16 -180 replies
5/10dma: sdma-imx: print an error when context load fails.drivers/dma/imx-sdma.c+4 -00 replies
6/10dma: imx-sdma: config in sdma_config_channel()drivers/dma/imx-sdma.c+17 -160 replies
7/10dma: imx-sdma: validate word size when setdrivers/dma/imx-sdma.c+7 -70 replies
8/10dma: imx-sdma: extract common sdma prep codedrivers/dma/imx-sdma.c+32 -440 replies
9/10dma: imx-sdma: use a for loopdrivers/dma/imx-sdma.c+2 -50 replies
10/10dma: imx-sdma: extract sdma_set_buffer_descriptor()drivers/dma/imx-sdma.c+54 -570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] imx-sdma cleanup

The primary purpose of this patch series, was to
combine common parts of sdma_prep_slave_sg() and
sdma_prep_dma_cyclic().

Code that is common between cyclic and slave
prep functions is combined, which also makes it easier to see how they meaningfully differ.

In addition, we remove several unneeded or duplicative variables from struct sdma_channel, add a few more printks on errors, and simplify some internal functions.

Tested on imx6q

Joshua Clayton (10):
dma: imx-sdma: constify local structs
dma: imx-sdma: pass sdma engine into functions
dma: imx-sdma: use a container_of function
dma: sdma-imx set dma script address directly
dma: sdma-imx: print an error when context load fails.
dma: imx-sdma: config in sdma_config_channel()
dma: imx-sdma: validate word size when set
dma: imx-sdma: extract common sdma prep code
dma: imx-sdma: use a for loop
dma: imx-sdma: extract sdma_set_buffer_descriptor()

 drivers/dma/imx-sdma.c | 387 +++++++++++++++++++++++--------------------------
 1 file changed, 185 insertions(+), 202 deletions(-)
Signature · 1 line
2.1.4