clean up wlan_bssdef.h
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest posting 2/28 patches 1 replyIn review
- v4 posting 1/28 patches 0 repliesSuperseded
- v38 patches 10 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 6 patches | 1 reply | Superseded | |
| v1 | 5 patches | 7 replies | Superseded |
Changes in v4 from the cover letter
In patch 8/8 Change the line wrapping of lines that fit within 80 characters, removing superfluous "== true" expressions that would otherwise keep the lines overlong.
Patches in v4 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | staging: rtl8712: fix buggy size calculationdrivers/ | +1 | 0 replies | |
| 2/8 | staging: rtl8712: simplify size calculationdrivers/ | +1 | 0 replies | |
| 3/8 | staging: rtl8712: fix commentdrivers/ | +1 | 0 replies | |
| 4/8 | staging: rtl8712: removed unused wrapper structsdrivers/ | +0 | 0 replies | |
| 5/8 | staging: rtl8712: remove duplicate structdrivers/ drivers/ drivers/ +4 more | +26 | 0 replies | |
| 6/8 | staging: rtl8712: rename functiondrivers/ drivers/ drivers/ +1 more | +14 | 0 replies | |
| 7/8 | staging: rtl8712: remove typedefsdrivers/ drivers/ | +7 | 0 replies | |
| 8/8 | staging: rtl8712: change SupportedRates to ratesdrivers/ drivers/ drivers/ | +20 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h
I posted v4 of this patch set a week ago and there have been no comments. I hope this is a good sign that the patches are good. However, I have noticed that I managed to use the same message id for the coverletter of v4 as for v3, which might have caused people to hold off reviewing, perhaps thinking that earlier comments had not been addressed.
Better safe than sorry, so I am reposting v4
My apologies for the noise on the mailing list.
The main goal of this series is to get rid of a needless typedef in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory) lead to a overrun during a memcpy, as well as an identical struct with a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary variable that used the typedef from "SupportedRates" to "rates", to conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates New patch 3/6 fixes a buggy comment that referred to the typedef
Changes since V2:
broke former patch 4 into 3 parts, as it was too big for git-send-email
Changes since V3:
In patch 8/8 Change the line wrapping of lines that fit within 80 characters, removing superfluous "== true" expressions that would otherwise keep the lines overlong.
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 25 +++++++------- drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- drivers/staging/rtl8712/rtl871x_event.h | 2 +- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 34 +++++++++---------- drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- 9 files changed, 62 insertions(+), 142 deletions(-)
Signature · 1 line
2.5.0