atp870u: Major rework
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v1 Latest posting 2/252 patches 1 replyIn review
- v1 posting 1/252 patches 2 repliesSuperseded
Patches in v1 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/52 | atp870u: Remove workportdrivers/ | +28 | 0 replies | |
| 2/52 | atp870u: Remove tmport1drivers/ | +3 | 0 replies | |
| 3/52 | atp870u: Untangle tmportdrivers/ | +71 | 0 replies | |
| 4/52 | atp870u: Untangle tmport #2drivers/ | +32 | 0 replies | |
| 5/52 | atp870u: Untangle tmport #3drivers/ | +49 | 0 replies | |
| 6/52 | atp870u: Untangle tmport #4drivers/ | +138 | 0 replies | |
| 7/52 | atp870u: Untangle tmport #5drivers/ | +173 | 0 replies | |
| 8/52 | atp870u: Untangle tmport #6drivers/ | +49 | 0 replies | |
| 9/52 | atp870u: Untangle tmport #7drivers/ | +5 | 0 replies | |
| 10/52 | atp870u: Untangle tmport #8drivers/ | +177 | 0 replies | |
| 11/52 | atp870u: Untangle tmpcipdrivers/ | +23 | 0 replies | |
| 12/52 | atp870u: Untangle tmpcip #2drivers/ | +9 | 0 replies | |
| 13/52 | atp870u: Remove ugly gotosdrivers/ | +30 | 0 replies | |
| 14/52 | atp870u: Remove ugly gotos #2drivers/ | +30 | 0 replies | |
| 15/52 | atp870u: Remove ugly gotos #3drivers/ | +6 | 0 replies | |
| 16/52 | atp870u: Remove ugly gotos #4drivers/ | +15 | 0 replies | |
| 17/52 | atp870u: Remove ugly gotos #5drivers/ | +62 | 0 replies | |
| 18/52 | atp870u: Introduce HW access wrappersdrivers/ | +252 | 0 replies | |
| 19/52 | atp870u: Convert is870() to use wrappersdrivers/ | +138 | 0 replies | |
| 20/52 | atp870u: Convert is880() to use wrappersdrivers/ | +176 | 0 replies | |
| 21/52 | atp870u: Convert is885() to use wrappersdrivers/ | +179 | 0 replies | |
| 22/52 | atp870u: Unify code format in is870(), is880() and is885()drivers/ | +101 | 0 replies | |
| 23/52 | atp870u: Add channel parameter to is870() and is880()drivers/ | +342 | 0 replies | |
| 24/52 | atp870u: Move chip-specific lines out of is880() and is885()drivers/ | +10 | 0 replies | |
| 25/52 | atp870u: Remove is880()drivers/ | +1 | 0 replies | |
| 26/52 | atp870u: Add wide_chip parameter to is870() and is885()drivers/ | +25 | 0 replies | |
| 27/52 | atp870u: Add remaining 870 support to is885()drivers/ | +31 | 0 replies | |
| 28/52 | atp870u: Move 870-specific code out of is870()drivers/ | +2 | 0 replies | |
| 29/52 | atp870u: Remove is870()drivers/ | +1 | 0 replies | |
| 30/52 | atp870u: Rename is885() to atp_is()drivers/ | +6 | 0 replies | |
| 31/52 | atp870u: Convert remaining in[bwl] and out[bwl] to wrappersdrivers/ | +118 | 0 replies | |
| 32/52 | atp870u: Replace port 0x80 delay by udelaydrivers/ | +9 | 0 replies | |
| 33/52 | atp870u: Fix incorrect writeb_io access to register 0x3adrivers/ | +4 | 0 replies | |
| 34/52 | atp870u: Introduce atp_set_host_iddrivers/ | +18 | 0 replies | |
| 35/52 | atp870u: Reduce log spam on module load/unloaddrivers/ | +1 | 0 replies | |
| 36/52 | atp870u: Remove empty tscam_885()drivers/ | +1 | 0 replies | |
| 37/52 | atp870u: Use module_pci_driverdrivers/ | +1 | 0 replies | |
| 38/52 | atp870u: Use n_io_port in request_region and release_regiondrivers/ | +3 | 0 replies | |
| 39/52 | atp870u: Remove useless and broken card countingdrivers/ | +4 | 0 replies | |
| 40/52 | atp870u: Remove unused irq from struct atp_unitdrivers/ | +0 | 0 replies | |
| 41/52 | atp870u: Improve _probe()drivers/ | +113 | 0 replies | |
| 42/52 | atp870u: Improve unsupported chip detectiondrivers/ | +8 | 0 replies | |
| 43/52 | atp870u: Remove chip_ver from struct atp_unitdrivers/ drivers/ | +14 | 0 replies | |
| 44/52 | atp870u: Simplify _probe()drivers/ | +28 | 0 replies | |
| 45/52 | atp870u: Introduce is880(), is885() and remove dev_iddrivers/ drivers/ | +38 | 0 replies | |
| 46/52 | atp870u: Use pci_request_regionsdrivers/ | +10 | 0 replies | |
| 47/52 | atp870u: Request IRQ later, remove weird lockingdrivers/ | +12 | 0 replies | |
| 48/52 | atp870u: Remove scam_on from struct atp_unitdrivers/ drivers/ | +7 | 0 replies | |
| 49/52 | atp870u: Initialize tables earlierdrivers/ | +6 | 0 replies | |
| 50/52 | atp870u: Introduce atp880_init()drivers/ | +88 | 0 replies | |
| 51/52 | atp870u: Introduce atp885_init()drivers/ | +113 | 0 replies | |
| 52/52 | atp870u: Introduce atp870_init()drivers/ | +54 | 0 replies |
Reviews trailers per patch
None of the 52 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Hannes Reinecke | Christoph Hellwig |
|---|---|---|
| Series | R-b | A-b |
| 1/52 | ||
| 2/52 | ||
| 3/52 | ||
| 4/52 | ||
| 5/52 | ||
| 6/52 | ||
| 7/52 | ||
| 8/52 | ||
| 9/52 | ||
| 10/52 | ||
| 11/52 | ||
| 12/52 | ||
| 13/52 | ||
| 14/52 | ||
| 15/52 | ||
| 16/52 | ||
| 17/52 | ||
| 18/52 | ||
| 19/52 | ||
| 20/52 | ||
| 21/52 | ||
| 22/52 | ||
| 23/52 | ||
| 24/52 | ||
| 25/52 | ||
| 26/52 | ||
| 27/52 | ||
| 28/52 | ||
| 29/52 | ||
| 30/52 | ||
| 31/52 | ||
| 32/52 | ||
| 33/52 | ||
| 34/52 | ||
| 35/52 | ||
| 36/52 | ||
| 37/52 | ||
| 38/52 | ||
| 39/52 | ||
| 40/52 | ||
| 41/52 | ||
| 42/52 | ||
| 43/52 | ||
| 44/52 | ||
| 45/52 | ||
| 46/52 | ||
| 47/52 | ||
| 48/52 | ||
| 49/52 | ||
| 50/52 | ||
| 51/52 | ||
| 52/52 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/52] [resend] atp870u: Major rework
This patch series removes the first level of crap from atp870u - the worst (in-tree) SCSI driver [1] and then cleans up the code a bit.
First the driver is converted to C from something that looks like a (bad) assembler code: use of tmport for all I/O accesses and gotos all over the code.
Then I/O access wrappers are introduced.
Finally, is870, is880 and is885 are unified and two of them removed.
After that, some cleanups are done. There's still a lot of work left to do.
Tested on AEC-6710D (ATP870IU-C).
[1] http://www.spinics.net/lists/linux-scsi/msg81142.html
atp870u.c | 3707 +++++++++++++++++--------------------------------------------- atp870u.h | 4 2 files changed, 1064 insertions(+), 2647 deletions(-)