Skip to content

atp870u: Major rework

Ondrej Zary linux-scsi 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/252 patches 1 replyIn review
  2. v1 posting 1/252 patches 2 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/52atp870u: Remove workportdrivers/scsi/atp870u.c+28 -310 replies
2/52atp870u: Remove tmport1drivers/scsi/atp870u.c+3 -40 replies
3/52atp870u: Untangle tmportdrivers/scsi/atp870u.c+71 -1150 replies
4/52atp870u: Untangle tmport #2drivers/scsi/atp870u.c+32 -470 replies
5/52atp870u: Untangle tmport #3drivers/scsi/atp870u.c+49 -690 replies
6/52atp870u: Untangle tmport #4drivers/scsi/atp870u.c+138 -2320 replies
7/52atp870u: Untangle tmport #5drivers/scsi/atp870u.c+173 -2970 replies
8/52atp870u: Untangle tmport #6drivers/scsi/atp870u.c+49 -870 replies
9/52atp870u: Untangle tmport #7drivers/scsi/atp870u.c+5 -110 replies
10/52atp870u: Untangle tmport #8drivers/scsi/atp870u.c+177 -3010 replies
11/52atp870u: Untangle tmpcipdrivers/scsi/atp870u.c+23 -410 replies
12/52atp870u: Untangle tmpcip #2drivers/scsi/atp870u.c+9 -160 replies
13/52atp870u: Remove ugly gotosdrivers/scsi/atp870u.c+30 -540 replies
14/52atp870u: Remove ugly gotos #2drivers/scsi/atp870u.c+30 -380 replies
15/52atp870u: Remove ugly gotos #3drivers/scsi/atp870u.c+6 -120 replies
16/52atp870u: Remove ugly gotos #4drivers/scsi/atp870u.c+15 -170 replies
17/52atp870u: Remove ugly gotos #5drivers/scsi/atp870u.c+62 -720 replies
18/52atp870u: Introduce HW access wrappersdrivers/scsi/atp870u.c+252 -2200 replies
19/52atp870u: Convert is870() to use wrappersdrivers/scsi/atp870u.c+138 -1380 replies
20/52atp870u: Convert is880() to use wrappersdrivers/scsi/atp870u.c+176 -1760 replies
21/52atp870u: Convert is885() to use wrappersdrivers/scsi/atp870u.c+179 -1790 replies
22/52atp870u: Unify code format in is870(), is880() and is885()drivers/scsi/atp870u.c+101 -690 replies
23/52atp870u: Add channel parameter to is870() and is880()drivers/scsi/atp870u.c+342 -3420 replies
24/52atp870u: Move chip-specific lines out of is880() and is885()drivers/scsi/atp870u.c+10 -140 replies
25/52atp870u: Remove is880()drivers/scsi/atp870u.c+1 -5710 replies
26/52atp870u: Add wide_chip parameter to is870() and is885()drivers/scsi/atp870u.c+25 -210 replies
27/52atp870u: Add remaining 870 support to is885()drivers/scsi/atp870u.c+31 -140 replies
28/52atp870u: Move 870-specific code out of is870()drivers/scsi/atp870u.c+2 -30 replies
29/52atp870u: Remove is870()drivers/scsi/atp870u.c+1 -4260 replies
30/52atp870u: Rename is885() to atp_is()drivers/scsi/atp870u.c+6 -60 replies
31/52atp870u: Convert remaining in[bwl] and out[bwl] to wrappersdrivers/scsi/atp870u.c+118 -1040 replies
32/52atp870u: Replace port 0x80 delay by udelaydrivers/scsi/atp870u.c+9 -90 replies
33/52atp870u: Fix incorrect writeb_io access to register 0x3adrivers/scsi/atp870u.c+4 -40 replies
34/52atp870u: Introduce atp_set_host_iddrivers/scsi/atp870u.c+18 -390 replies
35/52atp870u: Reduce log spam on module load/unloaddrivers/scsi/atp870u.c+1 -60 replies
36/52atp870u: Remove empty tscam_885()drivers/scsi/atp870u.c+1 -140 replies
37/52atp870u: Use module_pci_driverdrivers/scsi/atp870u.c+1 -190 replies
38/52atp870u: Use n_io_port in request_region and release_regiondrivers/scsi/atp870u.c+3 -170 replies
39/52atp870u: Remove useless and broken card countingdrivers/scsi/atp870u.c+4 -60 replies
40/52atp870u: Remove unused irq from struct atp_unitdrivers/scsi/atp870u.h+0 -10 replies
41/52atp870u: Improve _probe()drivers/scsi/atp870u.c+113 -1230 replies
42/52atp870u: Improve unsupported chip detectiondrivers/scsi/atp870u.c+8 -120 replies
43/52atp870u: Remove chip_ver from struct atp_unitdrivers/scsi/atp870u.c drivers/scsi/atp870u.h+14 -260 replies
44/52atp870u: Simplify _probe()drivers/scsi/atp870u.c+28 -370 replies
45/52atp870u: Introduce is880(), is885() and remove dev_iddrivers/scsi/atp870u.c drivers/scsi/atp870u.h+38 -330 replies
46/52atp870u: Use pci_request_regionsdrivers/scsi/atp870u.c+10 -110 replies
47/52atp870u: Request IRQ later, remove weird lockingdrivers/scsi/atp870u.c+12 -350 replies
48/52atp870u: Remove scam_on from struct atp_unitdrivers/scsi/atp870u.c drivers/scsi/atp870u.h+7 -80 replies
49/52atp870u: Initialize tables earlierdrivers/scsi/atp870u.c+6 -160 replies
50/52atp870u: Introduce atp880_init()drivers/scsi/atp870u.c+88 -860 replies
51/52atp870u: Introduce atp885_init()drivers/scsi/atp870u.c+113 -1180 replies
52/52atp870u: Introduce atp870_init()drivers/scsi/atp870u.c+54 -500 replies

Reviews trailers per patch

None of the 52 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHannes ReineckeChristoph Hellwig
SeriesR-b A-b
1/52
2/52
3/52
4/52
5/52
6/52
7/52
8/52
9/52
10/52
11/52
12/52
13/52
14/52
15/52
16/52
17/52
18/52
19/52
20/52
21/52
22/52
23/52
24/52
25/52
26/52
27/52
28/52
29/52
30/52
31/52
32/52
33/52
34/52
35/52
36/52
37/52
38/52
39/52
40/52
41/52
42/52
43/52
44/52
45/52
46/52
47/52
48/52
49/52
50/52
51/52
52/52

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/52] [resend] atp870u: Major rework

This patch series removes the first level of crap from atp870u - the worst (in-tree) SCSI driver [1] and then cleans up the code a bit.

First the driver is converted to C from something that looks like a (bad) assembler code: use of tmport for all I/O accesses and gotos all over the code.
Then I/O access wrappers are introduced.
Finally, is870, is880 and is885 are unified and two of them removed.

After that, some cleanups are done. There's still a lot of work left to do.

Tested on AEC-6710D (ATP870IU-C).

[1] http://www.spinics.net/lists/linux-scsi/msg81142.html

 atp870u.c | 3707 +++++++++++++++++---------------------------------------------
 atp870u.h |    4
 2 files changed, 1064 insertions(+), 2647 deletions(-)