Skip to content

fsnotify cleanups

Jan Kara linux-fsdevel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fsnotify: Document mark lockinginclude/linux/fsnotify_backend.h+30 -200 replies
2/3fsnotify: Remove mark->free_listfs/notify/fsnotify.c fs/notify/fsnotify.h fs/notify/inode_mark.c +3 more+40 -630 replies
3/3fsnotify: Get rid of fsnotify_destroy_mark_locked()fs/notify/dnotify/dnotify.c fs/notify/fanotify/fanotify_user.c fs/notify/mark.c +1 more+61 -410 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] fsnotify cleanups

Hello,

after understanding some of the fsnotify mark handling code when fixing
the last race I've decided to use that knowledge to improve the documentation and somewhat cleanup the code.

The first patch in the series documents locking rules for fsnotify marks. The second patch gets rid of special purpose free_list list head in the fsnotify mark structure and the third patch splits the fsnotify_destroy_mark_locked() function so that it doesn't have the awkward property of temporarily dropping mark_mutex which can cause unexpected issues in the caller.

All the patches have survived beating with LTP inotify and fanotify tests (including the test excercising inode & group destruction races).

Honza