Skip to content

irqchip, gicv3: Updates and Cavium ThunderX errata workarounds

Robert Richter linux-arm-kernel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 10 repliesIn review
  2. v45 patches 17 repliesSuperseded
  3. v36 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v25 patches7 repliesSuperseded

Changes in v5 from the cover letter

* fixed calling gic_read_iar_cavium_thunderx() if jump label is enabled
* fix table size wrongly allocating only 4MB
* made is_cavium_thunderx static
* removed ARCH_THUNDER dependency for Cavium errata options to make it available for generic kernels
* renamed caps names to quirk
* introduced CAVIUM_ERRATUM_22375 config option
* introduced ITS_FLAGS_WORKAROUND_CAVIUM_22375
* added config descriptions
* update to new jump label API

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6irqchip, gicv3-its: Add range check for number of allocated pagesdrivers/irqchip/irq-gic-v3-its.c include/linux/irqchip/arm-gic-v3.h+11 -10 replies
2/6irqchip, gicv3: Workaround for Cavium ThunderX erratum 23154arch/arm64/Kconfig arch/arm64/include/asm/cpufeature.h arch/arm64/include/asm/cputype.h +2 more+72 -91 reply
3/6irqchip, gicv3-its: Read typer register outside the loopdrivers/irqchip/irq-gic-v3-its.c+2 -30 replies
4/6irqchip, gicv3-its: Add HW revision detection and configurationdrivers/irqchip/irq-gic-common.c drivers/irqchip/irq-gic-common.h drivers/irqchip/irq-gic-v3-its.c+36 -01 reply
5/6irqchip, gicv3-its: Workaround for Cavium ThunderX errata 22375, 24313arch/arm64/Kconfig drivers/irqchip/irq-gic-v3-its.c+50 -41 reply
6/6irqchip, gicv3-its: Use new jump label APIdrivers/irqchip/irq-gic-v3.c+3 -31 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarc ZyngierCatalin Marinas
SeriesA-b
1/6R-b
2/6R-b
3/6A-b
4/6R-b
5/6R-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX errata workarounds

From: Robert Richter <[email protected]>

This patch series adds gicv3 updates and workarounds for HW errata in Cavium's ThunderX GICV3.

The patches has been rebased onto 4.3-rc1. Note that there are two important fixes. See below for all changes.

The first one is an unchanged resubmission of a patch from a gicv3 series I sent a while ago.

The next patches implement the workarounds for ThunderX's gicv3. Patch #2 implements the cpu workaround for gicv3 on ThunderX. Patch #3 is a prerequisit for patch #5. Patch #4 adds generic code to parse the hw revision provided by an IIDR. This patch is used for the implementa- tion of the actual gicv3-its workaround in #5. Patch #6 updates to the new jump label API.

All current review comments addressed so far with v5

v5:
* fixed calling gic_read_iar_cavium_thunderx() if jump label is enabled
* fix table size wrongly allocating only 4MB
* made is_cavium_thunderx static
* removed ARCH_THUNDER dependency for Cavium errata options to make it available for generic kernels
* renamed caps names to quirk
* introduced CAVIUM_ERRATUM_22375 config option
* introduced ITS_FLAGS_WORKAROUND_CAVIUM_22375
* added config descriptions
* update to new jump label API

v4:
* simplify code to only use cpus_have_cap() in gicv3_enable_quirks()
* only enable hw detection for its in its_enable_quirks()
* removed gicv3_check_capabilities()
* drop special cpu capability for zero

v3:
* use arm64 errata framework for midr check
* fix mixup of errata to be dependend from midr/iidr

v2:
* Workaround for 23154:
* implement code in a single asm() to keep instruction sequence
* added comment to the code that explains the erratum
* apply workaround also if running as guest, thus check MIDR
* adding MIDR check

Robert Richter (6):
irqchip, gicv3-its: Add range check for number of allocated pages irqchip, gicv3: Workaround for Cavium ThunderX erratum 23154 irqchip, gicv3-its: Read typer register outside the loop irqchip, gicv3-its: Add HW revision detection and configuration irqchip, gicv3-its: Workaround for Cavium ThunderX errata 22375, 24313 irqchip, gicv3-its: Use new jump label API

 arch/arm64/Kconfig                  | 27 +++++++++++++++
 arch/arm64/include/asm/cpufeature.h |  3 +-
 arch/arm64/include/asm/cputype.h    | 17 ++++++----
 arch/arm64/kernel/cpu_errata.c      |  9 +++++
 drivers/irqchip/irq-gic-common.c    | 11 +++++++
 drivers/irqchip/irq-gic-common.h    |  9 +++++
 drivers/irqchip/irq-gic-v3-its.c    | 65 +++++++++++++++++++++++++++++++++----
 drivers/irqchip/irq-gic-v3.c        | 42 +++++++++++++++++++++++-
 include/linux/irqchip/arm-gic-v3.h  |  1 +
 9 files changed, 169 insertions(+), 15 deletions(-)
Signature · 1 line
2.1.1