Skip to content

Fix handling of "default" project

Elliot Smith yocto-toaster 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyIn review
  2. v16 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6toaster: Make 0021 migration compatible with MySQLbitbake/lib/toaster/orm/migrations/0021_auto__chg_field_build_project__chg_field_project_bitbake_version__chg_.py+3 -10 replies
2/6toaster: Improve how default project is identified and fetchedbitbake/lib/bb/ui/buildinfohelper.py bitbake/lib/toaster/orm/migrations/0025_auto__add_field_project_is_default.py bitbake/lib/toaster/orm/migrations/0026_set_default_project.py +1 more+735 -60 replies
3/6toaster: Only redirect to projects page if user has added projectsbitbake/lib/toaster/toastergui/views.py+5 -10 replies
4/6toaster: Exclude default project unless it has buildsbitbake/lib/toaster/toastergui/views.py+8 -00 replies
5/6toaster: Fix test for projects page JSONbitbake/lib/toaster/toastergui/tests.py+5 -40 replies
6/6toaster: Add tests for pages which show the default projectbitbake/lib/toaster/toastergui/tests.py+114 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [review-request][PATCH 0/6] [v2] Fix handling of "default" project

This fixes how we handle the default project used to house command line builds. It originally started from a bug encountered when using MySQL for the db back-end, but fixing that revealed some other issues which needed to be resolved on top.

This is version 2, as the previous patch set incorrectly handled adding the is_default field to existing projects when using SQLite (due to a bug in South).

Changes since poky master 22afc047dd1b8f83e56c4a9862710776c509e3c5 are in
git://git.yoctoproject.org/poky-contrib, elliot/toaster/mysql-migrations
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/mysql-migrations

Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7932

Elliot Smith (6):
toaster: Make 0021 migration compatible with MySQL
toaster: Improve how default project is identified and fetched
toaster: Only redirect to projects page if user has added projects
toaster: Exclude default project unless it has builds
toaster: Fix test for projects page JSON
toaster: Add tests for pages which show the default project

 bitbake/lib/bb/ui/buildinfohelper.py               |   3 +-
 ...ect__chg_field_project_bitbake_version__chg_.py |   4 +-
 .../0025_auto__add_field_project_is_default.py     | 346 +++++++++++++++++++
 .../orm/migrations/0026_set_default_project.py     | 374 +++++++++++++++++++++
 bitbake/lib/toaster/orm/models.py                  |  18 +-
 bitbake/lib/toaster/toastergui/tests.py            | 124 ++++++-
 bitbake/lib/toaster/toastergui/views.py            |  14 +-
 7 files changed, 870 insertions(+), 13 deletions(-)
 create mode 100644 bitbake/lib/toaster/orm/migrations/0025_auto__add_field_project_is_default.py
 create mode 100644 bitbake/lib/toaster/orm/migrations/0026_set_default_project.py

--
Elliot Smith
Software Engineer
Intel OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.