Bluetooth: hci_bcm: Add wake-up and PM runtime support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 1 replyIn review
- v45 patches 3 repliesSuperseded
- v33 patches 7 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 4 patches | 10 replies | Superseded | |
| v1 | 2 patches | 3 replies | Superseded |
Changes in v5 from the cover letter
- Add bt_warn to to unify Bluetooth traces in BT_WARN
- Change bcm_suspend_device/bcm_resume_device prototype to be usable directly in SET_RUNTIME_PM_OPS. This allows to remove bcm_runtime_suspend/bcm_runtime_resume which just call bcm_suspend_device/bcm_resume_device.
- Update commit message and add comment in hci_uart_tty_receive to explain why spin_lock is not requested
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | Bluetooth: Add BT_WARN and bt_dev_warn logging macrosinclude/ net/ | +21 | 0 replies | |
| 2/5 | Bluetooth: hci_bcm: Fix IRQ polarity for T100drivers/ | +25 | 0 replies | |
| 3/5 | Bluetooth: hci_bcm: Prepare PM runtime supportdrivers/ | +60 | 0 replies | |
| 4/5 | Bluetooth: Remove useless rx_lock spinlockdrivers/ drivers/ | +3 | 0 replies | |
| 5/5 | Bluetooth: hci_bcm: Add suspend/resume runtime PM functionsdrivers/ | +56 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 0/5] Bluetooth: hci_bcm: Add wake-up and PM runtime support
Add wake-up capabilities by retrieveing interruption used by BCM device in ACPI table.
Add PM runtime support.
v4->v5:
- Add bt_warn to to unify Bluetooth traces in BT_WARN
- Change bcm_suspend_device/bcm_resume_device prototype to be usable directly in SET_RUNTIME_PM_OPS. This allows to remove bcm_runtime_suspend/bcm_runtime_resume which just call bcm_suspend_device/bcm_resume_device.
- Update commit message and add comment in hci_uart_tty_receive to explain why spin_lock is not requested
v3->v4:
- Add new BT_WARN and bt_dev_warn logging macros
- Use bt_dev_warn for T100 irq polarity fix
- Rename __bcm_suspend to bcm_suspend_device,
and __bcm_resume to bcm_resume_device
- Remove useless rx_lock spinlock. It is only used in hci_uart_tty_receive() which is the receive_buf ldisc callback. This is already protected by flush_to_ldisc() in drivers/tty/tty_buffer.c.
This allows to use mutex in bcm_recv() and call pm_runtime_* directly
- Remove pm_work Work queue which is now useless
- Delay auto-suspend only when reception of a packet is completed
v2->v3:
- Use DMI_EXACT_MATCH instead of DMI_MATCH
- Fix IRQ polarity for T100TA in driver_data of dmi_system_id struct
- Use dmi_first_match() instead of dmi_check_system()
v1->v2:
- Split 1st patch between general wake-up capability and T100TA IRQ fix
- Replace multiple "if ... else if" by switch in bcm_resource()
- Move code to limit number of #ifdef
- Use DMI info to restrict IRQ to T100TA
- Split 2nd patch to prepare PM runtime support in separated patch
- Tested with and without CONFIG_PM_SLEEP and CONFIG_PM.
Frederic Danis (5):
Bluetooth: Add BT_WARN and bt_dev_warn logging macros
Bluetooth: hci_bcm: Fix IRQ polarity for T100
Bluetooth: hci_bcm: Prepare PM runtime support
Bluetooth: Remove useless rx_lock spinlock
Bluetooth: hci_bcm: Add suspend/resume runtime PM functions
drivers/bluetooth/hci_bcm.c | 171 +++++++++++++++++++++++++++++++------- drivers/bluetooth/hci_ldisc.c | 8 +- drivers/bluetooth/hci_uart.h | 1 - include/net/bluetooth/bluetooth.h | 5 ++ net/bluetooth/lib.c | 16 ++++ 5 files changed, 164 insertions(+), 37 deletions(-)
Signature · 1 line
1.9.1