Skip to content

iotests: Emit signal-kill messages

Max Reitz qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesApplied
  2. v12 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Patch 1: Added, pulled in from v4 of my "blockdev: BlockBackend and media" series (needed in patch 2)
- Patch 2: Added, required because patch 3 now fixes argument handling for the Python iotests
- Patch 3:
- Fix handling of spaces in command filenames [Jeff]
- Fix argument handling for Python iotests (accidental fallout from the above)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4iotests: More options for VM.add_drive()tests/qemu-iotests/iotests.py+6 -30 replies
2/4iotests: Respect -nodefaults in tests 41 and 55tests/qemu-iotests/041 tests/qemu-iotests/055+16 -61 reply
3/4iotests: Do not suppress segfaults in bash teststests/qemu-iotests/039 tests/qemu-iotests/039.out tests/qemu-iotests/061 +5 more+67 -311 reply
4/4iotests: Warn if python subprocess is killedtests/qemu-iotests/iotests.py+21 -51 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/4] iotests: Emit signal-kill messages

Currently, if a qemu-related command (qemu, qemu-io, qemu-img, qemu-nbd) is invoked in an iotest, receives a signal and is subsequently killed (e.g. a segmentation fault), this is not logged in the test output. The first patch in this series makes the bash tests no longer suppress that line, and the second patch adds a similar notification for the python tests.

Patch 3 tries to fix some handling of spaces in command filenames, and apparently actually succeeds in doing so (all Python tests work, most bash tests work; if they fail, it's the test's fault). However, it does not fix handling of spaces in arguments: This is because we probably don't have to worry about that anyway, and because it would be pretty difficult to fix.

v2:
- Patch 1: Added, pulled in from v4 of my "blockdev: BlockBackend and media" series (needed in patch 2)
- Patch 2: Added, required because patch 3 now fixes argument handling for the Python iotests
- Patch 3:
- Fix handling of spaces in command filenames [Jeff]
- Fix argument handling for Python iotests (accidental fallout from the above)

git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/4:[down] 'iotests: More options for VM.add_drive()' 002/4:[down] 'iotests: Respect -nodefaults in tests 41 and 55' 003/4:[0047] [FC] 'iotests: Do not suppress segfaults in bash tests' 004/4:[----] [--] 'iotests: Warn if python subprocess is killed'

Max Reitz (4):
iotests: More options for VM.add_drive()
iotests: Respect -nodefaults in tests 41 and 55
iotests: Do not suppress segfaults in bash tests
iotests: Warn if python subprocess is killed

 tests/qemu-iotests/039           | 19 +++++----------
 tests/qemu-iotests/039.out       |  6 ++---
 tests/qemu-iotests/041           | 12 +++++++---
 tests/qemu-iotests/055           | 10 +++++---
 tests/qemu-iotests/061           |  6 +++--
 tests/qemu-iotests/061.out       |  2 ++
 tests/qemu-iotests/check         |  8 +++----
 tests/qemu-iotests/common.config | 29 +++++++++++++++++++----
 tests/qemu-iotests/common.rc     | 12 +++++++++-
 tests/qemu-iotests/iotests.py    | 51 ++++++++++++++++++++++++++++++----------
 10 files changed, 110 insertions(+), 45 deletions(-)
Signature · 1 line
2.5.1