mtd: spi-nor: cleanups + block protection support updates
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | mtd: spi-nor: make implicit <linux/bitops.h> dependency explicitinclude/ | +2 | 0 replies | |
| 2/10 | mtd: spi-nor: make bitfield constants more consistentinclude/ | +10 | 0 replies | |
| 3/10 | mtd: spi-nor: add SPI NOR manufacturer IDsinclude/ | +15 | 6 replies | |
| 4/10 | mtd: spi-nor: use SNOR_MFR_* instead of CFI_MFR_*drivers/ | +11 | 0 replies | |
| 5/10 | mtd: spi-nor: fixup kernel-doc for flash lock/unlock function pointersinclude/ | +2 | 0 replies | |
| 6/10 | mtd: spi-nor: refactor block protection functionsdrivers/ | +126 | 0 replies | |
| 7/10 | mtd: spi-nor: add mtd_is_locked() supportdrivers/ include/ | +39 | 6 replies | |
| 8/10 | mtd: spi-nor: add DUAL_READ for w25q{32,64}dwdrivers/ | +2 | 0 replies | |
| 9/10 | mtd: spi-nor: support lock/unlock/is_locked for Winbonddrivers/ | +3 | 0 replies | |
| 10/10 | mtd: spi-nor: disable protection for Winbond flash at startupdrivers/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/10] mtd: spi-nor: cleanups + block protection support updates
[Note: as this is sent out during the merge window, it's based on the semi-unofficial l2-mtd.git/next branch, which is targeting 4.4, not 4.3]
Hi all,
I've been reviewing various spi-nor drivers as well as working with some Winbond flash to support new locking features. The former helped point out a few more things that could use some improvement, and the latter suggested that we have some glaring oversights in the spi-nor lock/unlock code.
<side note>
Some helpful companion code, for mtd-utils:
http://lists.infradead.org/pipermail/linux-mtd/2015-August/061526.html
This extends the flash_lock tool so that you can more easily test specific ranges, using:
# flash_lock --lock /dev/mtdX <offset> <block-count> # flash_lock --unlock /dev/mtdX <offset> <block-count> # flash_lock --islocked /dev/mtdX <offset> <block-count> </side note>
The first half of this series is fairly self-explanatory. The second might take a bit of thought, as a formulaic approach is a little more subtle than a table-based approach, so I tried to copy the relevant portions distilled from a few datasheets and include comments. Please shout if anything deserves more explanation or looks funny to you.
Highlights:
* clean up spi-nor.h header
* spi-nor now supports MEMISLOCKED
* MEM{LOCK,UNLOCK} support is a little more robust and extendible
* turn on dual/quad read for Winbond w25q{32,64}dw
* enable block protection for Winbond flash
Regards,
Brian
Brian Norris (10):
mtd: spi-nor: make implicit <linux/bitops.h> dependency explicit
mtd: spi-nor: make bitfield constants more consistent
mtd: spi-nor: add SPI NOR manufacturer IDs
mtd: spi-nor: use SNOR_MFR_* instead of CFI_MFR_*
mtd: spi-nor: fixup kernel-doc for flash lock/unlock function pointers
mtd: spi-nor: refactor block protection functions
mtd: spi-nor: add mtd_is_locked() support
mtd: spi-nor: add DUAL_READ for w25q{32,64}dw
mtd: spi-nor: support lock/unlock/is_locked for Winbond
mtd: spi-nor: disable protection for Winbond flash at startup
drivers/mtd/spi-nor/spi-nor.c | 241 +++++++++++++++++++++++++++++++----------- include/linux/mtd/spi-nor.h | 44 +++++--- 2 files changed, 211 insertions(+), 74 deletions(-)
Signature · 1 line
2.5.0.457.gab17608