Skip to content

perf tools: Cleanup filesystem api

Jiri Olsa lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 41 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15perf tools: Fix parse_events_add_pmu callertools/perf/util/parse-events.y+1 -12 replies
2/15perf tools: Remove mountpoint arg from perf_debugfs_mounttools/perf/perf.c tools/perf/util/util.c tools/perf/util/util.h+9 -90 replies
3/15perf tools: Move tracing_path stuff under same namespacetools/perf/perf.c tools/perf/util/util.c tools/perf/util/util.h+18 -160 replies
4/15perf tools: Move tracing_path interface into api/fs/tracing_path.ctools/lib/api/fs/Build tools/lib/api/fs/tracing_path.c tools/lib/api/fs/tracing_path.h +6 more+101 -792 replies
5/15tools lib api: Move debugfs__strerror_open into tracing_path.c objecttools/lib/api/fs/debugfs.c tools/lib/api/fs/tracing_path.c tools/lib/api/fs/tracing_path.h +1 more+60 -545 replies
6/15tools lib api: Make tracing_path_strerror_open message generictools/lib/api/fs/tracing_path.c+10 -103 replies
7/15tools lib api: Add STR and PATH_MAX macros to fs objecttools/lib/api/fs/fs.c tools/lib/api/fs/fs.h+11 -00 replies
8/15tools lib api: Move SYSFS_MAGIC PROC_SUPER_MAGIC into fs.ctools/lib/api/fs/fs.c tools/lib/api/fs/fs.h+8 -80 replies
9/15tools lib api: Add debugfs into fs.c objecttools/lib/api/fs/fs.c tools/lib/api/fs/fs.h+26 -60 replies
10/15tools lib api: Add tracefs into fs.c objecttools/lib/api/fs/fs.c tools/lib/api/fs/fs.h+29 -00 replies
11/15tools lib api: Add mount support for fstools/lib/api/fs/fs.c tools/lib/api/fs/fs.h+50 -96 replies
12/15tools lib api: Add configured support for fstools/lib/api/fs/fs.c tools/lib/api/fs/fs.h+18 -108 replies
13/15tools lib api: Replace debugfs/tracefs objects interface with fs.ctools/lib/api/fs/fs.c tools/lib/api/fs/tracing_path.c tools/perf/builtin-kvm.c +8 more+23 -290 replies
14/15tools lib api: Remove debugfs, tracefs and findfs objectstools/lib/api/fs/Build tools/lib/api/fs/debugfs.c tools/lib/api/fs/debugfs.h +4 more+0 -28814 replies
15/15perf tools: Switch to tracing_path interface on appropriate placestools/perf/tests/openat-syscall-all-cpus.c tools/perf/tests/openat-syscall.c tools/perf/tests/parse-events.c +1 more+11 -390 replies

Reviews trailers per patch

3 of 15 patches have a Reviewed-by or Acked-by.

PatchMatt FlemingRaphaël Beamonte
1/15
2/15
3/15
4/15R-b R-b
5/15R-b R-b
6/15
7/15
8/15
9/15
10/15
11/15R-b
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] perf tools: Cleanup filesystem api

hi,
this patchset moves all filesystem we use under api/fs/fs.c framework and adds new tracing_path object to get tracing area (path).

It unifies the way we use debugfs/tracefs paths and removes some redundant code.

It's base for the tracepoint parsing error reporting I posted recently.

jirka

---
Jiri Olsa (15):
perf tools: Fix parse_events_add_pmu caller
perf tools: Remove mountpoint arg from perf_debugfs_mount perf tools: Move tracing_path stuff under same namespace perf tools: Move tracing_path interface into api/fs/tracing_path.c tools lib api: Move debugfs__strerror_open into tracing_path.c object tools lib api: Make tracing_path_strerror_open message generic tools lib api: Add STR and PATH_MAX macros to fs object tools lib api: Move SYSFS_MAGIC PROC_SUPER_MAGIC into fs.c tools lib api: Add debugfs into fs.c object
tools lib api: Add tracefs into fs.c object
tools lib api: Add mount support for fs
tools lib api: Add configured support for fs
tools lib api: Replace debugfs/tracefs objects interface with fs.c tools lib api: Remove debugfs, tracefs and findfs objects perf tools: Switch to tracing_path interface on appropriate places

 tools/lib/api/fs/Build                     |   4 +--
 tools/lib/api/fs/debugfs.c                 | 129 -----------------------------------------------------------------------------------
 tools/lib/api/fs/debugfs.h                 |  23 ---------------
 tools/lib/api/fs/findfs.c                  |  63 -----------------------------------------
 tools/lib/api/fs/findfs.h                  |  23 ---------------
 tools/lib/api/fs/fs.c                      | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------
 tools/lib/api/fs/fs.h                      |  26 ++++++++++++-----
 tools/lib/api/fs/tracefs.c                 |  78 --------------------------------------------------
 tools/lib/api/fs/tracefs.h                 |  21 --------------
 tools/lib/api/fs/tracing_path.c            | 136 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tools/lib/api/fs/tracing_path.h            |  16 +++++++++++
 tools/perf/builtin-kvm.c                   |   1 -
 tools/perf/builtin-probe.c                 |   1 -
 tools/perf/builtin-trace.c                 |   5 ++--
 tools/perf/perf.c                          |  12 ++++----
 tools/perf/tests/openat-syscall-all-cpus.c |  10 +++----
 tools/perf/tests/openat-syscall.c          |  10 +++----
 tools/perf/tests/parse-events.c            |  19 ++-----------
 tools/perf/util/evsel.c                    |   2 +-
 tools/perf/util/parse-events.c             |   2 +-
 tools/perf/util/parse-events.y             |   2 +-
 tools/perf/util/probe-event.c              |   5 ++--
 tools/perf/util/probe-file.c               |  15 ++--------
 tools/perf/util/trace-event-info.c         |   2 +-
 tools/perf/util/trace-event.c              |   1 +
 tools/perf/util/util.c                     |  70 ---------------------------------------------
 tools/perf/util/util.h                     |   9 +-----
 27 files changed, 310 insertions(+), 493 deletions(-)
 delete mode 100644 tools/lib/api/fs/debugfs.c
 delete mode 100644 tools/lib/api/fs/debugfs.h
 delete mode 100644 tools/lib/api/fs/findfs.c
 delete mode 100644 tools/lib/api/fs/findfs.h
 delete mode 100644 tools/lib/api/fs/tracefs.c
 delete mode 100644 tools/lib/api/fs/tracefs.h
 create mode 100644 tools/lib/api/fs/tracing_path.c
 create mode 100644 tools/lib/api/fs/tracing_path.h