Skip to content

regulator: Fix pbias regulator enable

Kishon Vijay Abraham I linux-arm-kernel linux-devicetree linux-mmc linux-omap lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v26 patches 4 repliesSuperseded
  3. v16 patches 2 repliesSuperseded

Changes in v3 from the cover letter

*) Squashed all the dt patches into a single patch

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2regulator: pbias: program pbias register offset in pbias driverDocumentation/devicetree/bindings/regulator/pbias-regulator.txt drivers/regulator/pbias-regulator.c+56 -71 reply
2/2ARM: dts: <omap2/3/4/5/dra7>: use "ti,pbias-<platform>" compatible string for pbiasarch/arm/boot/dts/dra7.dtsi arch/arm/boot/dts/omap2430.dtsi arch/arm/boot/dts/omap3.dtsi +2 more+5 -50 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchTony Lindgren
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] regulator: Fix pbias regulator enable

vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon.

However after
"ARM: dts: <platform>: add minimal l4 bus layout with control module support"
vsel_reg and enable_reg started to have the absolute address because of address translation that happens due to pbias node made as the child node of syscon. This breaks the pbias regulator enable.

This series adds the 'offset' to be populated in vsel_reg and enable_reg in the pbias driver itself.

Changes from v2:
*) Squashed all the dt patches into a single patch

Changes from v1:
*) Fixed Tony's review comments on adding a 'comment' for adding offset in
the driver and adding a warning for using platform_get_resource.
*) Added Tony's Acked-by.

Tested these patches against mmc -next in omap4 panda, omap3 beagle xm, dra72 and omap5 uevm

Kishon Vijay Abraham I (2):
regulator: pbias: program pbias register offset in pbias driver
ARM: dts: <omap2/3/4/5/dra7>: use "ti,pbias-<platform>" compatible
string for pbias

 .../bindings/regulator/pbias-regulator.txt         |    7 ++-
 arch/arm/boot/dts/dra7.dtsi                        |    2 +-
 arch/arm/boot/dts/omap2430.dtsi                    |    2 +-
 arch/arm/boot/dts/omap3.dtsi                       |    2 +-
 arch/arm/boot/dts/omap4.dtsi                       |    2 +-
 arch/arm/boot/dts/omap5.dtsi                       |    2 +-
 drivers/regulator/pbias-regulator.c                |   56 +++++++++++++++++---
 7 files changed, 61 insertions(+), 12 deletions(-)
Signature · 1 line
1.7.9.5