Skip to content

RFC refactor eal driver registration code

Bernard Iremonger dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest18 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18librte_eal: remove type field from rte_driver structure.lib/librte_eal/common/eal_common_dev.c lib/librte_eal/common/include/rte_dev.h+14 -191 reply
2/18af_packet: remove type field from rte_driver structuredrivers/net/af_packet/rte_eth_af_packet.c+2 -30 replies
3/18bnx2x: remove type field and initialise name field in rte_driver structuredrivers/net/bnx2x/bnx2x_ethdev.c+3 -21 reply
4/18bonding: remove type field from rte_driver structuredrivers/net/bonding/rte_eth_bond_pmd.c+1 -20 replies
5/18cxgbe: remove type field from rte_driver structuredrivers/net/cxgbe/cxgbe_ethdev.c+2 -20 replies
6/18e1000: remove type field and initialise name field in rte_driver structuresdrivers/net/e1000/em_ethdev.c drivers/net/e1000/igb_ethdev.c+3 -30 replies
7/18enic: remove type field and initialise name field in rte_driver structuredrivers/net/enic/enic_ethdev.c+2 -10 replies
8/18fm10k: remove type field and initialise name field in rte_driver structuredrivers/net/fm10k/fm10k_ethdev.c+1 -10 replies
9/18i40e: remove type field and initialise name field in rte_driver structuresdrivers/net/i40e/i40e_ethdev.c drivers/net/i40e/i40e_ethdev_vf.c+2 -20 replies
10/18ixgbe: remove type field and initialise name field in rte_driver structuredrivers/net/ixgbe/ixgbe_ethdev.c+2 -20 replies
11/18mlx4: remove type field from rte_driver structuredrivers/net/mlx4/mlx4.c+2 -20 replies
12/18mpipe: remove type field and update name in rte_driver structuredrivers/net/mpipe/mpipe_tilegx.c+3 -40 replies
13/18null: remove type field from rte_driver structuredrivers/net/null/rte_eth_null.c+1 -20 replies
14/18pcap: remove type field from rte_driver structuredrivers/net/pcap/rte_eth_pcap.c+1 -20 replies
15/18ring: remove type field from rte_driver structuredrivers/net/ring/rte_eth_ring.c+1 -20 replies
16/18virtio_ethdev: remove type field and initialise name field in rte_driver structuredrivers/net/virtio/virtio_ethdev.c+1 -10 replies
17/18vmxnet3: remove type field and initialise name field in rte_driver structuredrivers/net/vmxnet3/vmxnet3_ethdev.c+1 -10 replies
18/18xenvirt: remove type field from rte_driver structuredrivers/net/xenvirt/rte_eth_xenvirt.c+2 -30 replies

Reviews trailers per patch

1 of 18 patches has a Reviewed-by or Acked-by.

PatchHarish Patil
1/18
2/18
3/18A-b
4/18
5/18
6/18
7/18
8/18
9/18
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/18] refactor eal driver registration code

At present the eal driver registration code is more complicated than it needs to be.

This RFC proposes to simplify the eal driver registration code.

Remove the type field from the eal driver structure. Refactor the eal driver registration code to use the name field in the eal driver structure instead of the type field.

Modify all PMD's to use the modified eal driver structure. Initialise the name field in the eal driver structure in some PMD's where it is not initialised at present.

Bernard Iremonger (18):
librte_eal: remove type field from rte_driver structure.
af_packet: remove type field from rte_driver structure
bnx2x: remove type field and initialise name field in rte_driver
structure
bonding: remove type field from rte_driver structure
cxgbe: remove type field from rte_driver structure
e1000: remove type field and initialise name field in rte_driver
structures
enic: remove type field and initialise name field in rte_driver
structure
fm10k: remove type field and initialise name field in rte_driver
structure
i40e: remove type field and initialise name field in rte_driver
structures
ixgbe: remove type field and initialise name field in rte_driver
structure
mlx4: remove type field from rte_driver structure
mpipe: remove type field and update name in rte_driver structure
null: remove type field from rte_driver structure
pcap: remove type field from rte_driver structure
ring: remove type field from rte_driver structure
virtio_ethdev: remove type field and initialise name field in
rte_driver structure
vmxnet3: remove type field and initialise name field in rte_driver
structure
xenvirt: remove type field from rte_driver structure

 drivers/net/af_packet/rte_eth_af_packet.c |  5 ++---
 drivers/net/bnx2x/bnx2x_ethdev.c          |  5 +++--
 drivers/net/bonding/rte_eth_bond_pmd.c    |  3 +--
 drivers/net/cxgbe/cxgbe_ethdev.c          |  4 ++--
 drivers/net/e1000/em_ethdev.c             |  2 +-
 drivers/net/e1000/igb_ethdev.c            |  4 ++--
 drivers/net/enic/enic_ethdev.c            |  3 ++-
 drivers/net/fm10k/fm10k_ethdev.c          |  2 +-
 drivers/net/i40e/i40e_ethdev.c            |  2 +-
 drivers/net/i40e/i40e_ethdev_vf.c         |  2 +-
 drivers/net/ixgbe/ixgbe_ethdev.c          |  4 ++--
 drivers/net/mlx4/mlx4.c                   |  4 ++--
 drivers/net/mpipe/mpipe_tilegx.c          |  7 +++----
 drivers/net/null/rte_eth_null.c           |  3 +--
 drivers/net/pcap/rte_eth_pcap.c           |  3 +--
 drivers/net/ring/rte_eth_ring.c           |  3 +--
 drivers/net/virtio/virtio_ethdev.c        |  2 +-
 drivers/net/vmxnet3/vmxnet3_ethdev.c      |  2 +-
 drivers/net/xenvirt/rte_eth_xenvirt.c     |  5 ++---
 lib/librte_eal/common/eal_common_dev.c    | 22 +++++++++++++---------
 lib/librte_eal/common/include/rte_dev.h   | 11 +----------
 21 files changed, 44 insertions(+), 54 deletions(-)
Signature · 1 line
1.9.1