Skip to content

perf tools: Fix gaps propagating maps

Adrian Hunter lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 5 repliesIn review
  2. v214 patches 7 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in V2 from the cover letter

Split into multiple patches
Add evsel->own_cpus to identify evsels with their own cpu map And consequently don't need to unpropagate

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14perf tools: Simplify perf_evlist__propagate_maps logictools/perf/util/evlist.c+2 -30 replies
2/14perf tools: Simplify perf_evlist__set_maps logictools/perf/util/evlist.c+2 -60 replies
3/14perf tools: Remove redundant validation from perf_evlist__propagate_mapstools/perf/util/evlist.c tools/perf/util/evlist.h+10 -160 replies
4/14perf tools: Add evlist->has_user_cpustools/perf/util/evlist.c tools/perf/util/evlist.h+7 -50 replies
5/14perf tools: Fix perf_evlist__splice_list_tail not setting evlisttools/perf/util/evlist.c tools/perf/util/evlist.h tools/perf/util/parse-events.c+9 -120 replies
6/14perf tools: Fix missing thread_map__put in perf_evlist__propagate_mapstools/perf/util/evlist.c+1 -00 replies
7/14perf tools: Add evsel->own_cpustools/perf/util/evlist.c tools/perf/util/evsel.c tools/perf/util/evsel.h +1 more+8 -30 replies
8/14perf tools: Make perf_evlist__set_maps() more resilienttools/perf/util/evlist.c+15 -40 replies
9/14perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()tools/perf/util/evlist.c+10 -90 replies
10/14perf tools: Factor out a function to propagate maps for a single evseltools/perf/util/evlist.c+21 -160 replies
11/14perf tools: Fix perf_evlist__add() not propagating mapstools/perf/util/evlist.c+29 -271 reply
12/14perf tools: Fix perf_evlist__create_syswide_maps() not propagating mapstools/perf/util/evlist.c+10 -90 replies
13/14perf tools: Fix task exit test setting mapstools/perf/tests/task-exit.c+14 -40 replies
14/14perf tools: Fix software clock events test setting mapstools/perf/tests/sw-clock.c+14 -40 replies

Reviews trailers per patch

1 of 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJiri Olsa
SeriesA-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14A-b A-b
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 00/14] perf tools: Fix gaps propagating maps

Hi

Here is V3 of "Fix gaps propagating maps" that fixes some problems revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")

Changes in V3:

perf tools: Remove redundant validation from perf_evlist__propagate_maps
perf_evlist__set_maps also doesn't need to return an error anymore

perf tools: Add evlist->has_user_cpus
Adjusted due to perf_evlist__set_maps change

perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()
Adjusted due to perf_evlist__set_maps change

perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps
Adjusted due to perf_evlist__set_maps change

perf tools: Fix task exit test setting maps
Adjusted due to perf_evlist__set_maps change

perf tools: Fix software clock events test setting maps
Adjusted due to perf_evlist__set_maps change

Changes in V2:
Split into multiple patches
Add evsel->own_cpus to identify evsels with their own cpu map And consequently don't need to unpropagate

perf tools: Fix perf_evlist__splice_list_tail not setting evlist
New patch

perf tools: Fix task exit test setting maps
New patch

perf tools: Fix software clock events test setting maps
New patch

Adrian Hunter (14):
perf tools: Simplify perf_evlist__propagate_maps logic
perf tools: Simplify perf_evlist__set_maps logic
perf tools: Remove redundant validation from perf_evlist__propagate_maps perf tools: Add evlist->has_user_cpus
perf tools: Fix perf_evlist__splice_list_tail not setting evlist perf tools: Fix missing thread_map__put in perf_evlist__propagate_maps perf tools: Add evsel->own_cpus
perf tools: Make perf_evlist__set_maps() more resilient perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps() perf tools: Factor out a function to propagate maps for a single evsel perf tools: Fix perf_evlist__add() not propagating maps perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps perf tools: Fix task exit test setting maps
perf tools: Fix software clock events test setting maps

 tools/perf/tests/sw-clock.c    |  18 ++++--
 tools/perf/tests/task-exit.c   |  18 ++++--
 tools/perf/util/evlist.c       | 138 +++++++++++++++++++++++------------------
 tools/perf/util/evlist.h       |   9 ++-
 tools/perf/util/evsel.c        |   1 +
 tools/perf/util/evsel.h        |   1 +
 tools/perf/util/parse-events.c |   7 +--
 7 files changed, 113 insertions(+), 79 deletions(-)

Regards
Adrian