Skip to content

Input: xpad: updates and refactoring

Pavel Rojtberg linux-input 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Input: xpad: add Covert Forces edition of the Xbox One controllerdrivers/input/joystick/xpad.c+1 -00 replies
2/6Input: xpad: clarify LED enumerationdrivers/input/joystick/xpad.c+8 -120 replies
3/6Input: xpad: remove needless bulk out URB used for LED setupdrivers/input/joystick/xpad.c+1 -780 replies
4/6Input: xpad: factor out URB submission in xpad_play_effectdrivers/input/joystick/xpad.c+69 -710 replies
5/6Input: xpad: x360w: report dpad as buttons and axesdrivers/input/joystick/xpad.c+16 -20 replies
6/6Input: xpad: reset usb device on resumedrivers/input/joystick/xpad.c+24 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Input: xpad: updates and refactoring

From: Pavel Rojtberg <[email protected]>

This series contains several bug-fixes and updates for the xpad driver. They are loosely sorted in order of controversy.

Patch 1 just adds a new device id for the Xbox One controller. The original patch was sent to me via github: https://github.com/paroj/xpad/pull/9

Patches 2-4 are minor refactorings of the code that should make it more maintainable.

Patch 5 makes the x360 wireless pads support the x360 wired button interface. See the commit message for details and a link to the preceding discussion.

Patch 6 fixes issues of the x360 wireless pads after suspend/ resume.

Erik Lundgren (1):
Input: xpad: add Covert Forces edition of the Xbox One controller

Pavel Rojtberg (5):
Input: xpad: clarify LED enumeration
Input: xpad: remove needless bulk out URB used for LED setup
Input: xpad: factor out URB submission in xpad_play_effect
Input: xpad: x360w: report dpad as buttons and axes
Input: xpad: reset usb device on resume

 drivers/input/joystick/xpad.c | 286 +++++++++++++++++++++++++++--------------------------------------
 1 file changed, 119 insertions(+), 167 deletions(-)
Signature · 1 line
1.9.1