vhost-user multiple queue support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v12 Latest7 patches 0 repliesNew
- v117 patches 14 repliesSuperseded
- v107 patches 16 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v9 | 7 patches | 16 replies | Superseded | |
| v8 | 6 patches | 1 reply | Superseded | |
| v7 | 7 patches | 23 replies | Superseded |
Patches in v12 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | vhost-user: use VHOST_USER_XXX macro for switch statementhw/ | +22 | 0 replies | |
| 2/7 | vhost-user: add protocol feature negotiationdocs/ hw/ hw/ +1 more | +71 | 0 replies | |
| 3/7 | vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICEdocs/ hw/ hw/ +2 more | +8 | 0 replies | |
| 4/7 | vhost-user: add VHOST_USER_GET_QUEUE_NUM messagedocs/ hw/ hw/ +2 more | +40 | 0 replies | |
| 5/7 | vhost: introduce vhost_backend_get_vq_index methodhw/ hw/ hw/ +1 more | +27 | 0 replies | |
| 6/7 | vhost-user: add multiple queue supportdocs/ hw/ hw/ +4 more | +152 | 0 replies | |
| 7/7 | vhost-user: add a new message to disable/enable a specific virt queue.docs/ hw/ hw/ +3 more | +60 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Marcel Apfelbaum | Jason Wang |
|---|---|---|
| 1/7 | R-b T-b | |
| 2/7 | R-b T-b | |
| 3/7 | R-b T-b | |
| 4/7 | R-b T-b | |
| 5/7 | T-b | R-b |
| 6/7 | T-b | R-b |
| 7/7 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v12 0/7] vhost-user multiple queue support
Hi,
Here is the updated patch set for enabling vhost-user multiple queue. It works well in my test, and it also passes Marcel's testing (thank him for testing!).
---
There are only few minor changes comparing with last version, such as typo fixes, function rename, and something else.
The reason I made another formal version is, after addressing all comments I got so far, that I hope Michael could consider to merge this patch set. And if it's still not ready, Michael, please kindly tell me so that I can fix them.
----
This patch set introduces 2 more vhost user messages: VHOST_USER_GET_QUEUE_NUM, for querying how many queues the backend supports, and VHOST_USER_SET_VRING_ENABLE, for enabling/disabling a specific virt queue.
Both of the two new messages are treated as vhost protocol extension, and that's why Michaels's patch "vhost-user: add protocol feature negotiation" is also included here.
Patch 1-5 are all prepare works for actually enabling multiple queue.
Patch 6 is the major patch for enabling multiple queue, which also tries to address two major concerns from Michael: no feedback from backend if it can't support # of requested queues, and all messages are sent N time. It also fixes a hidden bug.
Patch 7 introduces the VHOST_USER_SET_VRING_ENABLE message, to enable or disable a specific vring.
v12: - typo fixes, function rename, and so on.
v11: - typo fixes pointed out by Eric
- define a dummy vhost_net_get_max_queues() when !CONFIG_VHOST_NET.
- Per suggested by Jason Wang, invoke qmp_set_link() directly to remove duplicate code.
v10: - typo fixes pointed out by Eric
- [PATCH 6]: don't treat VHOST_USER_SET/GET_[PROTOCOL]_FEATURES as one time request, as the two feature bits need to be stored at per-device.
v9: - Per suggested by Jason Wang, patch 5 introduces a new vhost
backend method: vhost_backend_get_vq_index().
- Use qemu_find_net_clients_except() at net/vhost-user.c for gathering all related ncs so that we could register chr dev event handler once. Which is also suggested by Jason Wang.
Thanks.
--yliu
---
Changchun Ouyang (2):
vhost-user: add multiple queue support
vhost-user: add a new message to disable/enable a specific virt queue.
Michael S. Tsirkin (1):
vhost-user: add protocol feature negotiation
Yuanhan Liu (4):
vhost-user: use VHOST_USER_XXX macro for switch statement
vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE
vhost-user: add VHOST_USER_GET_QUEUE_NUM message
vhost: introduce vhost_backend_get_vq_index method
docs/specs/vhost-user.txt | 78 ++++++++++++++++++++- hw/net/vhost_net.c | 54 ++++++++++++--- hw/net/virtio-net.c | 8 +++ hw/virtio/vhost-backend.c | 10 ++- hw/virtio/vhost-user.c | 139 +++++++++++++++++++++++++++++++------ hw/virtio/vhost.c | 20 +++--- include/hw/virtio/vhost-backend.h | 4 ++ include/hw/virtio/vhost.h | 2 + include/net/vhost_net.h | 3 + linux-headers/linux/vhost.h | 2 +- net/vhost-user.c | 141 +++++++++++++++++++++++++------------- qapi-schema.json | 6 +- qemu-options.hx | 5 +- tests/vhost-user-test.c | 2 +- 14 files changed, 377 insertions(+), 97 deletions(-)
Signature · 1 line
1.9.0