Skip to content

Drivers: hv: Miscellaneous fixes

K. Y. Srinivasan lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvscdrivers/hv/channel_mgmt.c+17 -00 replies
2/5hv: add helpers to handle hv_util device statedrivers/hv/hyperv_vmbus.h+14 -09 replies
3/5hv: fcopy: use wrappers to propagate statedrivers/hv/hv_fcopy.c+20 -160 replies
4/5hv: kvp: use wrappers to propaigate statedrivers/hv/hv_kvp.c+21 -184 replies
5/5hv: vss: use wrappers to propagate statedrivers/hv/hv_snapshot.c+20 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Drivers: hv: Miscellaneous fixes

The Copy-VMFile cmdlet on the host may fail because the guest fcopy driver state machine gets out of sync. This happens because the ->state and ->context variables are accessed by the main thread and from interrupt context. If an interrupt happens between fcopy_respond_to_host and hv_poll_channel in fcopy_write, then hv_fcopy_onchannelcallback called from that interrupt sees still state HVUTIL_USERSPACE_RECV. It updates the context, but fcopy_write will not notice that update and hv_poll_channel gets called with an empty context. As a result hv_fcopy_daemon gets no more data. After a timeout Copy-VMFile fails with timeout.

In my initial testing for a fix I put a "mb()" after the last .state change in fcopy_write. But this series implementes read/write memory barriers as needed. Let me know if this is overdoing things.

Dexuan Cui (1):
Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

Olaf Hering (4):
hv: add helpers to handle hv_util device state
hv: fcopy: use wrappers to propagate state
hv: kvp: use wrappers to propaigate state
hv: vss: use wrappers to propagate state

 drivers/hv/channel_mgmt.c |   17 +++++++++++++++++
 drivers/hv/hv_fcopy.c     |   36 ++++++++++++++++++++----------------
 drivers/hv/hv_kvp.c       |   39 +++++++++++++++++++++------------------
 drivers/hv/hv_snapshot.c  |   37 ++++++++++++++++++++-----------------
 drivers/hv/hyperv_vmbus.h |   14 ++++++++++++++
 5 files changed, 92 insertions(+), 51 deletions(-)
Signature · 1 line
1.7.4.1