Skip to content

RFC fix *pbl format support

Maurizio Lombardi linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lib/vsprintf.c: Do not pass printf_spec by value on stack.lib/vsprintf.c+118 -1070 replies
2/3lib/vsprintf.c: append "..." if the *pb[l] output has been truncated.lib/vsprintf.c+48 -00 replies
3/3lib/vsprintf.c: increase the size of the field_width variablelib/vsprintf.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] fix *pbl format support

Hi,

I tried to fix the "*pb[l]" format issue while taking care of the problems discussed in this thread:

https://lkml.org/lkml/2015/9/9/153

I would like to know whether this approach is more acceptable to you:

PATCH 1 modifies the code so that the printf_spec struct is not passed by value anymore, instead a const pointer is used and the structure is copied to a local variable only when necessary.

PATCH 2 modifies the bitmap_*_string() functions so they'll append "..." to the output string whenever the buffer is not sufficiently large.

example of output:

*pb: cccccccc,...
*pbl: 1-2,5-7,...

PATCH 3 increases the size of printf_spec.field_width (from s16 to s32).

Maurizio Lombardi (3):
lib/vsprintf.c: Do not pass printf_spec by value on stack. lib/vsprintf.c: append "..." if the *pb[l] output has been truncated. lib/vsprintf.c: increase the size of the field_width variable

 lib/vsprintf.c | 275 +++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 167 insertions(+), 108 deletions(-)
Signature · 1 line
Maurizio Lombardi