block: Get rid of bdrv_swap()
Status from this message: Applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest16 patches 19 repliesApplied
- v216 patches 21 repliesSuperseded
- v116 patches 51 repliesSuperseded
Changes in v3 from the cover letter
- Patch 4 ('quorum: Convert to BdrvChild')
Fixed stale comment [Max]
- Patch 7 ('block: Convert bs->backing_hd to BdrvChild') Simplified bdrv_find_overlay() [Fam]
- Patch 8 ('block: Manage backing file references in bdrv_set_backing_hd()') Fixed leaks in bdrv_drop_intermediate() [Berto]
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | block: Introduce BDS.file_childblock.c include/ | +10 | 1 reply | |
| 2/16 | vmdk: Use BdrvChild instead of BDS for references to extentsblock/ | +51 | 1 reply | |
| 3/16 | blkverify: Convert s->test_file to BdrvChildblock/ | +21 | 1 reply | |
| 4/16 | quorum: Convert to BdrvChildblock/ | +34 | 1 reply | |
| 5/16 | block: Convert bs->file to BdrvChildblock.c block/ block/ +23 more | +378 | 2 replies | |
| 6/16 | block: Remove bdrv_open_image()block.c include/ | +0 | 1 reply | |
| 7/16 | block: Convert bs->backing_hd to BdrvChildblock.c block/ block/ +11 more | +115 | 4 replies | |
| 8/16 | block: Manage backing file references in bdrv_set_backing_hd()block.c block/ block/ +2 more | +37 | 2 replies | |
| 9/16 | block: Split bdrv_move_feature_fields()block.c | +12 | 1 reply | |
| 10/16 | block/io: Make bdrv_requests_pending() publicblock/ include/ | +2 | 0 replies | |
| 11/16 | block-backend: Add blk_set_bs()block/ include/ | +19 | 0 replies | |
| 12/16 | block: Introduce parents listblock.c include/ | +5 | 0 replies | |
| 13/16 | block: Implement bdrv_append() without bdrv_swap()block.c blockdev.c | +85 | 3 replies | |
| 14/16 | blockjob: Store device name at job creationblock/ blockjob.c include/ | +17 | 0 replies | |
| 15/16 | block: Add and use bdrv_replace_in_backing_chain()block.c block/ include/ +1 more | +49 | 0 replies | |
| 16/16 | block: Remove bdrv_swap()block.c block/ block/ +2 more | +1 | 0 replies |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Max Reitz | Alberto Garcia | Fam Zheng | Jeff Cody | Stefan Hajnoczi |
|---|---|---|---|---|---|
| Series | R-b | ||||
| 1/16 | R-b | R-b | R-b | R-b | |
| 2/16 | R-b | R-b | R-b | R-b | |
| 3/16 | R-b | R-b | R-b | R-b | |
| 4/16 | R-b | R-b | R-b | R-b | |
| 5/16 | R-b | R-b | R-b | ||
| 6/16 | R-b | R-b | R-b | R-b | |
| 7/16 | R-b | R-b | |||
| 8/16 | R-b | R-b | |||
| 9/16 | R-b | R-b | R-b | ||
| 10/16 | R-b | R-b | R-b | ||
| 11/16 | R-b | R-b | R-b | ||
| 12/16 | R-b | R-b | |||
| 13/16 | R-b | R-b | |||
| 14/16 | R-b | R-b | R-b | ||
| 15/16 | R-b | R-b | |||
| 16/16 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [Qemu-devel] [PATCH v3 00/16] block: Get rid of bdrv_swap()
bdrv_swap() has always been an ugly hack that we would rather have avoided. When it was introduced, we simply didn't have the infrastructure to update pointers instead of transplanting the contents of BDS object, so we grudgingly added bdrv_swap() as a quick solution. Meanwhile, most of the infrastructure exists and this series implements the final step necessary to implement the required functionality in a less adventurous way.
v3:
- Patch 4 ('quorum: Convert to BdrvChild')
Fixed stale comment [Max]
- Patch 7 ('block: Convert bs->backing_hd to BdrvChild') Simplified bdrv_find_overlay() [Fam]
- Patch 8 ('block: Manage backing file references in bdrv_set_backing_hd()') Fixed leaks in bdrv_drop_intermediate() [Berto]
v2:
- Patch 4 ('quorum: Convert to BdrvChild')
Use bdrv_unref_child() instead of bdrv_unref() [Berto]
- Patch 5 ('block: Convert bs->file to BdrvChild')
bdrv_close: Set bs->drv = NULL immediately after .bdrv_close [Berto]
bdrv_close: bdrv_unref_child() instead of bdrv_unref() for bs->file [Max]
- Patch 7 ('block: Convert bs->backing_hd to BdrvChild')
Use backing_bs() more consistently instead of open-coding and introducing additional bugs while doing so [Max]
- Patch 8 ('block: Manage backing file references in bdrv_set_backing_hd()')
mirror: Use backing instead of s->base->backing->bs [Max]
stream: More simplication, remove close_unused_images() altogether [Berto]
- Patch 11 ('block-backend: Add blk_set_bs()')
assert(bs->blk == NULL) [Max]
- Patch 13 ('block: Implement bdrv_append() without bdrv_swap()') bdrv_ref/unref in change_parent_backing_link [Max] Improved throttle state handling in swap_feature_fields() [Berto] Fixed external_snapshot_commit() [Berto]
- Patch 14 ('blockjob: Store device name at job creation') Use new job->id more consistently [Max]
Kevin Wolf (16):
block: Introduce BDS.file_child
vmdk: Use BdrvChild instead of BDS for references to extents
blkverify: Convert s->test_file to BdrvChild
quorum: Convert to BdrvChild
block: Convert bs->file to BdrvChild
block: Remove bdrv_open_image()
block: Convert bs->backing_hd to BdrvChild
block: Manage backing file references in bdrv_set_backing_hd()
block: Split bdrv_move_feature_fields()
block/io: Make bdrv_requests_pending() public
block-backend: Add blk_set_bs()
block: Introduce parents list
block: Implement bdrv_append() without bdrv_swap()
blockjob: Store device name at job creation
block: Add and use bdrv_replace_in_backing_chain()
block: Remove bdrv_swap()
block.c | 486 ++++++++++++++++++---------------------------- block/blkdebug.c | 32 +-- block/blkverify.c | 68 ++++--- block/block-backend.c | 17 ++ block/bochs.c | 8 +- block/cloop.c | 10 +- block/dmg.c | 20 +- block/io.c | 76 ++++---- block/mirror.c | 22 +-- block/parallels.c | 38 ++-- block/qapi.c | 10 +- block/qcow.c | 46 ++--- block/qcow2-cache.c | 11 +- block/qcow2-cluster.c | 42 ++-- block/qcow2-refcount.c | 45 +++-- block/qcow2-snapshot.c | 30 +-- block/qcow2.c | 68 +++---- block/qed-table.c | 4 +- block/qed.c | 51 +++-- block/quorum.c | 65 ++++--- block/raw_bsd.c | 40 ++-- block/snapshot.c | 12 +- block/stream.c | 34 +--- block/vdi.c | 17 +- block/vhdx-log.c | 25 +-- block/vhdx.c | 36 ++-- block/vmdk.c | 133 +++++++------ block/vpc.c | 34 ++-- block/vvfat.c | 19 +- blockdev.c | 6 +- blockjob.c | 15 +- include/block/block.h | 15 +- include/block/block_int.h | 20 +- include/block/blockjob.h | 8 + include/qemu/queue.h | 6 - qemu-img.c | 20 +- 36 files changed, 754 insertions(+), 835 deletions(-)
Signature · 1 line
1.8.3.1