Skip to content

bridge: don't age out externally added FDB entries

[email protected] netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 3 repliesIn review
  2. v27 patches 3 repliesSuperseded
  3. v17 patches 17 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7rocker: track when FDB entry is touched.drivers/net/ethernet/rocker/rocker.c+12 -60 replies
2/7rocker: store rocker_port in fdb key rather than pportdrivers/net/ethernet/rocker/rocker.c+4 -40 replies
3/7bridge: define some min/max/default ageing time constantsinclude/linux/if_bridge.h net/bridge/br_device.c+7 -11 reply
4/7rocker: adding port ageing_time for ageing out FDB entriesdrivers/net/ethernet/rocker/rocker.c+2 -01 reply
5/7rocker: add FDB cleanup timerdrivers/net/ethernet/rocker/rocker.c+42 -00 replies
6/7bridge: don't age externally added FDB entriesnet/bridge/br_fdb.c+2 -00 replies
7/7switchdev: update documentation on FDB ageing_timeDocumentation/networking/switchdev.txt+12 -120 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoVivien DidelotPremkumar Jonnala
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b A-b A-b
7/7A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 0/7] bridge: don't age out externally added FDB entries

From: Scott Feldman <[email protected]>

v3: Per davem review: add del_timer_sync on rocker port remove.

v2: Per Jiri review comment: add BR_DEFAULT_AGEING_TIME to defines

Siva originally proposed skipping externally added FDB entries in the bridge's FDB garbage collection func, and moving the ageing of externally added entries to the port driver/device. This broke rocker, since rocker didn't have a hardware (or software) mechanism for ageing out its learned FDB entries.

This patchset reintroduces Siva's bridge driver patch to skip externally added entries and adds support in rocker so rocker can age out its own entries. Rocker does this using a software timer similar to the bridge's FDB garbage collection timer. Other switchdev devices/drivers can use this software timer method or program the device to nofity aged-out entries to the driver.

Updated switchdev.txt documentation to reflect current state-of-the-art. This removes one more XXX todo comment in switchdev.txt.

Scott Feldman (6):
rocker: track when FDB entry is touched.
rocker: store rocker_port in fdb key rather than pport
bridge: define some min/max/default ageing time constants
rocker: adding port ageing_time for ageing out FDB entries
rocker: add FDB cleanup timer
switchdev: update documentation on FDB ageing_time

Siva Mannem (1):
bridge: don't age externally added FDB entries

 Documentation/networking/switchdev.txt |   24 +++++------
 drivers/net/ethernet/rocker/rocker.c   |   70 +++++++++++++++++++++++++++-----
 include/linux/if_bridge.h              |    6 +++
 net/bridge/br_device.c                 |    2 +-
 net/bridge/br_fdb.c                    |    2 +
 5 files changed, 81 insertions(+), 23 deletions(-)
Signature · 1 line
1.7.10.4