Skip to content

mrf24j40: async rx/tx handling and new features

Alexander Aring linux-wpan 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 1 replyIn review

changes since PATCH from the cover letter

- add warning for edge triggered irq's
- add patch to replace magic numbers, except hw_init which is specified by datasheet instruction
- remove WARN_ON for max_be
- fix cca mode setting s/OR/AND
- add warning for spi freq is above maximum
- let txpower also working for mrf24j40 chips by default
- re-add DEBUG things for rssi and lqi value
- add several reviewed-by's
- use for cca_ed_thres register regmap_write instead update bits with full 0xff mask

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22mrf24j40: cleanup define identationdrivers/net/ieee802154/mrf24j40.c+38 -380 replies
2/22mrf24j40: use ieee802154_alloc_hw for private datadrivers/net/ieee802154/mrf24j40.c+15 -160 replies
3/22mrf24j40: calling ieee802154_register_hw at lastdrivers/net/ieee802154/mrf24j40.c+7 -100 replies
4/22mrf24j40: remove spi settings overwritedrivers/net/ieee802154/mrf24j40.c+5 -30 replies
5/22mrf24j40: add device-tree supportDocumentation/devicetree/bindings/net/ieee802154/mrf24j40.txt MAINTAINERS drivers/net/ieee802154/mrf24j40.c+30 -00 replies
6/22mrf24j40: add default channel settingdrivers/net/ieee802154/mrf24j40.c+7 -00 replies
7/22mrf24j40: add random extended addr generationdrivers/net/ieee802154/mrf24j40.c+1 -00 replies
8/22mrf24j40: add more register definesdrivers/net/ieee802154/mrf24j40.c+68 -00 replies
9/22mrf24j40: add regmap supportdrivers/net/ieee802154/Kconfig drivers/net/ieee802154/mrf24j40.c+313 -00 replies
10/22mrf24j40: use regmap for register accessdrivers/net/ieee802154/mrf24j40.c+50 -970 replies
11/22mrf24j40: change to frame delivery with crcdrivers/net/ieee802154/mrf24j40.c+1 -40 replies
12/22ieee802154: add helpers for frame control checksinclude/linux/ieee802154.h+12 -00 replies
13/22mrf24j40: rework tx handling to async tx handlingdrivers/net/ieee802154/mrf24j40.c+78 -830 replies
14/22mrf24j40: rework rx handling to async rx handlingdrivers/net/ieee802154/mrf24j40.c+118 -1640 replies
15/22mrf24j40: async interrupt handlingdrivers/net/ieee802154/mrf24j40.c+40 -530 replies
16/22mrf24j40: add csma params supportdrivers/net/ieee802154/mrf24j40.c+26 -10 replies
17/22mrf24j40: add cca mode supportdrivers/net/ieee802154/mrf24j40.c+40 -00 replies
18/22mrf24j40: add cca ed level supportdrivers/net/ieee802154/mrf24j40.c+49 -10 replies
19/22mrf24j40: add tx power supportdrivers/net/ieee802154/mrf24j40.c+71 -00 replies
20/22mrf24j40: add promiscuous mode supportdrivers/net/ieee802154/mrf24j40.c+21 -10 replies
21/22mrf24j40: change irq trigger type behaviourdrivers/net/ieee802154/mrf24j40.c+28 -30 replies
22/22mrf24j40: replace magic numbersdrivers/net/ieee802154/mrf24j40.c+98 -380 replies

Reviews trailers per patch

18 of 22 patches have a Reviewed-by or Acked-by.

PatchStefan Schmidt
1/22R-b
2/22R-b
3/22R-b
4/22R-b
5/22R-b
6/22R-b
7/22R-b
8/22R-b
9/22R-b
10/22R-b
11/22R-b
12/22R-b
13/22R-b
14/22R-b
15/22R-b
16/22
17/22R-b
18/22R-b
19/22
20/22R-b
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bluetooth-next 00/22] mrf24j40: async rx/tx handling and new features

Hi,

this patch series contains some cleanups, devicetree support, rx/tx async handling, threaded irq to hardirq, csma params settings, cca mode settings, cca energy detection levels, tx power settings and promiscuous mode settings.

Also I add regmap support, the lowlevel spi calls are only used in hotpaths for handling receive/transmit and irq handling. There are also some many magic numbers, maybe we can introduce some register bits defines.

- Alex

changes since PATCH:

- add warning for edge triggered irq's
- add patch to replace magic numbers, except hw_init which is specified by datasheet instruction
- remove WARN_ON for max_be
- fix cca mode setting s/OR/AND
- add warning for spi freq is above maximum
- let txpower also working for mrf24j40 chips by default
- re-add DEBUG things for rssi and lqi value
- add several reviewed-by's
- use for cca_ed_thres register regmap_write instead update bits with full 0xff mask

Alexander Aring (22):
mrf24j40: cleanup define identation
mrf24j40: use ieee802154_alloc_hw for private data
mrf24j40: calling ieee802154_register_hw at last
mrf24j40: remove spi settings overwrite
mrf24j40: add device-tree support
mrf24j40: add default channel setting
mrf24j40: add random extended addr generation
mrf24j40: add more register defines
mrf24j40: add regmap support
mrf24j40: use regmap for register access
mrf24j40: change to frame delivery with crc
ieee802154: add helpers for frame control checks
mrf24j40: rework tx handling to async tx handling
mrf24j40: rework rx handling to async rx handling
mrf24j40: async interrupt handling
mrf24j40: add csma params support
mrf24j40: add cca mode support
mrf24j40: add cca ed level support
mrf24j40: add tx power support
mrf24j40: add promiscuous mode support
mrf24j40: change irq trigger type behaviour
mrf24j40: replace magic numbers

 .../bindings/net/ieee802154/mrf24j40.txt           |   20 +
 MAINTAINERS                                        |    1 +
 drivers/net/ieee802154/Kconfig                     |    1 +
 drivers/net/ieee802154/mrf24j40.c                  | 1424 ++++++++++++++------
 include/linux/ieee802154.h                         |   12 +
 5 files changed, 1031 insertions(+), 427 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/ieee802154/mrf24j40.txt
Signature · 1 line
2.5.2