ide: avoid main-loop hang on CDROM/NFS failure
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest6 patches 9 repliesIn review
- v36 patches 10 repliesSuperseded
- v24 patches 13 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 5 patches | 26 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | ide/atapi: make PIO read requests asynchw/ | +85 | 2 replies | |
| 2/6 | block: add blk_abort_aio_requestblock/ include/ | +12 | 0 replies | |
| 3/6 | ide: add support for IDEBufferedRequesthw/ hw/ | +61 | 0 replies | |
| 4/6 | ide: orphan all buffered requests on DMA cancelhw/ | +19 | 0 replies | |
| 5/6 | ide: enable buffered requests for ATAPI deviceshw/ | +5 | 0 replies | |
| 6/6 | ide: enable buffered requests for PIO read requestshw/ | +2 | 0 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | John Snow | Fam Zheng |
|---|---|---|
| Series | R-b | R-b |
| 1/6 | R-b | |
| 2/6 | ||
| 3/6 | ||
| 4/6 | ||
| 5/6 | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH V4 0/6] ide: avoid main-loop hang on CDROM/NFS failure
This series aims at avoiding a hanging main-loop if a vserver has a CDROM image mounted from a NFS share and that NFS share goes down. Typical situation is that users mount an CDROM ISO to install something and then forget to eject that CDROM afterwards.
As a consequence this mounted CD is able to bring down the whole vserver if the backend NFS share is unreachable. This is bad especially if the CDROM itself is not needed anymore at this point.
v3->v4: - Patch 1: remove buf argument for cd_read_sector{_sync}
- Patch 1: fix iov_base offset for 2352 sector size
- Patch 2: fix indent [Fam]
- Patch 3: fix leaking of req->iov.iov_base [Fam]
v2->v3: - adressed Stefans comments on Patch 1
- added patches 2,4,5,6
- avoided the term cancel in Patch 3. Added an iovec, added a BH [Stefan]v1->v2: - fix offset for 2352 byte sector size [Kevin]
- use a sync request if we continue an elementary transfer. As John pointed out we enter a race condition between next IDE command and async transfer otherwise. This is sill not optimal, but it fixes the NFS down problems for all cases where the NFS server goes down while there is no PIO CD activity. Of course, it could still happen during a PIO transfer, but I expect this to be the unlikelier case.
I spent some effort trying to read more sectors at once and avoiding continuation of elementary transfers, but with whatever I came up it was destroying migration between different Qemu versions. I have a quite hackish patch that works and should survive migration, but I am not happy with it. So I would like to start with this version as it is a big improvement already.
- Dropped Patch 5 because it is upstream meanwhile.
Peter Lieven (6):
ide/atapi: make PIO read requests async
block: add blk_abort_aio_request
ide: add support for IDEBufferedRequest
ide: orphan all buffered requests on DMA cancel
ide: enable buffered requests for ATAPI devices
ide: enable buffered requests for PIO read requests
block/block-backend.c | 17 +++---- hw/ide/atapi.c | 103 +++++++++++++++++++++++++++++++++++------ hw/ide/core.c | 51 +++++++++++++++++++- hw/ide/internal.h | 14 ++++++ hw/ide/pci.c | 19 ++++++++ include/sysemu/block-backend.h | 3 ++ 6 files changed, 182 insertions(+), 25 deletions(-)
Signature · 1 line
1.9.1