Skip to content

x86/mm: Implement lockless pgd_alloc()/pgd_free()

Ingo Molnar linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11x86/mm/pat: Don't free PGD entries on memory unmaparch/x86/mm/pageattr.c+0 -152 replies
2/11x86/mm/hotplug: Remove pgd_list use from the memory hotplug codearch/x86/mm/init_64.c+26 -124 replies
3/11x86/mm/hotplug: Don't remove PGD entries in remove_pagetable()arch/x86/mm/init_64.c+0 -275 replies
4/11x86/mm/hotplug: Simplify sync_global_pgds()arch/x86/include/asm/pgtable_64.h arch/x86/mm/fault.c arch/x86/mm/init_64.c+10 -220 replies
5/11mm: Introduce arch_pgd_init_late()arch/Kconfig arch/x86/Kconfig arch/x86/mm/init_64.c +4 more+106 -06 replies
6/11x86/virt/guest/xen: Remove use of pgd_list from the Xen guest codearch/x86/xen/mmu.c+39 -62 replies
7/11x86/mm: Remove pgd_list use from vmalloc_sync_all()arch/x86/mm/fault.c+22 -71 reply
8/11x86/mm/pat/32: Remove pgd_list use from the PAT codearch/x86/mm/pageattr.c+22 -30 replies
9/11x86/mm: Make pgd_alloc()/pgd_free() locklessarch/x86/mm/pgtable.c+3 -240 replies
10/11x86/mm: Remove pgd_list leftoversarch/x86/include/asm/pgtable.h arch/x86/mm/fault.c arch/x86/mm/pgtable.c+0 -300 replies
11/11x86/mm: Simplify pgd_alloc()arch/x86/mm/pgtable.c+9 -180 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchDavid Vrabel
1/11
2/11
3/11
4/11
5/11
6/11R-b
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] x86/mm: Implement lockless pgd_alloc()/pgd_free()

So this is the somewhat belated latest iteration of the series. I (think I) fixed all correctness bugs in the code pointed out by Oleg.

The task list walk is still 'dumb', using for_each_process(), as none of the call sites are performance critical.

Oleg, can you see any problems with this code?

Background:

Waiman Long reported 'pgd_lock' contention on high CPU count systems and proposed moving pgd_lock on a separate cacheline to eliminate false sharing and to reduce some of the lock bouncing overhead.

I think we can do much better: this series eliminates the pgd_list and makes pgd_alloc()/pgd_free() lockless.

Now the lockless initialization of the PGD has a few preconditions, which the initial part of the series implements:

- no PGD clearing is allowed, only additions. This makes sense as a single PGD entry covers 512 GB of RAM so the 4K overhead per 0.5TB of RAM mapped is miniscule.

The patches after that convert existing pgd_list users to walk the task list.

PGD locking is kept intact: coherency guarantees between the CPA, vmalloc, hotplug, etc. code are unchanged.

The final patches eliminate the pgd_list and thus make pgd_alloc()/pgd_free() lockless.

The patches have been boot tested on 64-bit and 32-bit x86 systems.

Architectures not making use of the new facility are unaffected.

Thanks,

Ingo

===
Ingo Molnar (11):
x86/mm/pat: Don't free PGD entries on memory unmap x86/mm/hotplug: Remove pgd_list use from the memory hotplug code x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() x86/mm/hotplug: Simplify sync_global_pgds()
mm: Introduce arch_pgd_init_late()
x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code x86/mm: Remove pgd_list use from vmalloc_sync_all() x86/mm/pat/32: Remove pgd_list use from the PAT code x86/mm: Make pgd_alloc()/pgd_free() lockless
x86/mm: Remove pgd_list leftovers
x86/mm: Simplify pgd_alloc()

 arch/Kconfig                      |   9 +++
 arch/x86/Kconfig                  |   1 +
 arch/x86/include/asm/pgtable.h    |   3 -
 arch/x86/include/asm/pgtable_64.h |   3 +-
 arch/x86/mm/fault.c               |  32 +++++++---
 arch/x86/mm/init_64.c             |  92 ++++++++++++--------------
 arch/x86/mm/pageattr.c            |  40 ++++++------
 arch/x86/mm/pgtable.c             | 131 +++++++++++++++++++-------------------
 arch/x86/xen/mmu.c                |  45 +++++++++++--
 fs/exec.c                         |   3 +
 include/linux/mm.h                |   6 ++
 kernel/fork.c                     |  16 +++++
 12 files changed, 227 insertions(+), 154 deletions(-)

--
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>