RFC vnc buffer handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest10 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | io/ makefile fluffMakefile Makefile.objs Makefile.target | +9 | 0 replies | |
| 2/10 | io: pull Buffer code out of VNC moduleinclude/ io/ io/ +9 more | +276 | 1 reply | |
| 3/10 | vnc: make the Buffer capacity increase in powers of twoio/ | +4 | 0 replies | |
| 4/10 | io: add qio_buffer_initinclude/ io/ | +23 | 1 reply | |
| 5/10 | io: add qio_buffer_move_emptyinclude/ io/ | +24 | 1 reply | |
| 6/10 | io: add qio_buffer_moveinclude/ io/ | +26 | 1 reply | |
| 7/10 | io: add qio_buffer tracingio/ trace-events | +16 | 1 reply | |
| 8/10 | name vnc buffersui/ ui/ | +17 | 2 replies | |
| 9/10 | vnc: kill jobs queue bufferui/ | +0 | 1 reply | |
| 10/10 | vnc-jobs: move buffer reset, use new buffer moveui/ | +3 | 1 reply |
Reviews trailers per patch
5 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Peter Lieven |
|---|---|
| 1/10 | |
| 2/10 | R-b |
| 3/10 | |
| 4/10 | R-b |
| 5/10 | R-b |
| 6/10 | R-b |
| 7/10 | |
| 8/10 | |
| 9/10 | R-b |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [RfC PATCH 00/10] vnc buffer handling
Hi,
Here is a patch series to improve the vnc buffer handling. It picks up the qio_buffer patches from Daniel, adds move calls (move data from one buffer to another) and tracing, makes vnc use the new features. Net effect should be that (a) vnc copies less data around and (b) buffers don't grow forever.
It's RfC because it depends on wip patches. My plan is to wait for Daniels patch series to be merged (which should obsolete patches #1+#2), then rebase and repost the series.
Patches are also available from git:
git://git.kraxel.org/qemu rebase/ui-vnc-next
please test & review,
Gerd
Daniel P. Berrange (1):
io: pull Buffer code out of VNC module
Gerd Hoffmann (8):
io/ makefile fluff
io: add qio_buffer_init
io: add qio_buffer_move_empty
io: add qio_buffer_move
io: add qio_buffer tracing
name vnc buffers
vnc: kill jobs queue buffer
vnc-jobs: move buffer reset, use new buffer move
Peter Lieven (1):
vnc: make the Buffer capacity increase in powers of two
Makefile | 2 + Makefile.objs | 5 ++ Makefile.target | 2 + include/io/buffer.h | 150 ++++++++++++++++++++++++++++++++++++++++++++++++++++ io/Makefile.objs | 1 + io/buffer.c | 119 +++++++++++++++++++++++++++++++++++++++++ trace-events | 6 +++ ui/vnc-auth-sasl.c | 4 +- ui/vnc-enc-tight.c | 38 ++++++------- ui/vnc-enc-zlib.c | 6 +-- ui/vnc-enc-zrle.c | 18 +++---- ui/vnc-jobs.c | 16 ++---- ui/vnc-ws.c | 36 ++++++------- ui/vnc-ws.h | 6 +-- ui/vnc.c | 83 ++++++++++------------------- ui/vnc.h | 50 +++++++----------- 16 files changed, 389 insertions(+), 153 deletions(-) create mode 100644 include/io/buffer.h create mode 100644 io/Makefile.objs create mode 100644 io/buffer.c
Signature · 1 line
1.8.3.1