Skip to content

Fix cooker log download button

Elliot Smith yocto-toaster 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2toaster: Manually retrieve log file location from filesystembitbake/lib/bb/ui/toasterui.py+30 -10 replies
2/2toaster: Hide "Download build log" button if log doesn't existbitbake/lib/toaster/toastergui/templates/builddashboard.html+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [review-request][PATCH 0/2][v2] Fix cooker log download button

This supersedes https://lists.yoctoproject.org/pipermail/toaster/2015-September/002877.html
(which was a single commit).

* Retrieve a build's log file location directly from the file system, as the one which is available at the time of the BuildStarted event is incorrect.

* Hide the "Download build log" button for builds which fail early (e.g. due to recipe parsing) and consequently have no cooker_log_path.

Changes since 986f6b04b26bba9d01393f8f4ced4e0f4385368a (toaster-next) are in
git://git.yoctoproject.org/poky-contrib, elliot/toaster/wrong_log-8373
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/wrong_log-8373

Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373

Elliot Smith (2):
toaster: Manually retrieve log file location from filesystem
toaster: Hide "Download build log" button if log doesn't exist

 bitbake/lib/bb/ui/toasterui.py                     | 31 +++++++++++++++++++++-
 .../toastergui/templates/builddashboard.html       |  4 ++-
 2 files changed, 33 insertions(+), 2 deletions(-)

--
Elliot Smith
Software Engineer
Intel OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.