make non-modular code explicitly non-modular
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 3 repliesIn review
- v16 patches 4 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | net/core: make sock_diag.c explicitly non-modularnet/ | +3 | 0 replies | |
| 2/4 | net/dcb: make dcbnl.c explicitly non-modularnet/ | +3 | 0 replies | |
| 3/4 | net/sched: make sch_blackhole.c explicitly non-modularnet/ | +3 | 2 replies | |
| 4/4 | drivers/net/ethernet: make ti/cpsw-phy-sel.c explicitly non-modulardrivers/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH-next v2 0/4] make non-modular code explicitly non-modular
[v2: drop m68k patches that Geert converted to modules; add one ARM
driver patch ; update net-next baseline to today; switch to ARM for build testing.]
In a previous merge window, we made changes to allow better delineation between modular and non-modular code in commit 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init from init.h to module.h"). This allows us to now ensure module code looks modular and non-modular code does not accidentally look modular just to avoid suffering build breakage.
Here we target code that is, by nature of their Makefile and/or Kconfig settings, only available to be built-in, but implicitly presenting itself as being possibly modular by way of using modular headers, macros, and functions.
The goal here is to remove that illusion of modularity from these files, but in a way that leaves the actual runtime unchanged. In doing so, we remove code that has never been tested and adds no value to the tree. And we continue the process of expecting a level of consistency between the Kconfig/Makefile of code and the code in use itself.
Fortuntately the net subsystem has relatively few instances, given the overall amount of code and drivers it contains. For comparison there are over 300 instances tree wide, resulting in a possible net removal of on the order of 5000 lines of unused code.
Build tested on net-next from today, on ARM, since that is the arch where the one ethernet driver changed here is available.
Paul.
--
Paul Gortmaker (4):
net/core: make sock_diag.c explicitly non-modular net/dcb: make dcbnl.c explicitly non-modular
net/sched: make sch_blackhole.c explicitly non-modular drivers/net/ethernet: make ti/cpsw-phy-sel.c explicitly non-modular
drivers/net/ethernet/ti/cpsw-phy-sel.c | 10 ++++------ net/core/sock_diag.c | 14 +++----------- net/dcb/dcbnl.c | 30 +++--------------------------- net/sched/sch_blackhole.c | 15 +++------------ 4 files changed, 13 insertions(+), 56 deletions(-)
Signature · 1 line
2.6.0.rc3