RFC netfilter: introduce new chain type for local socket input
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | netfilter: add socket to struct nft_pktinfoinclude/ | +2 | 1 reply | |
| 2/7 | netfilter: nft_meta: look at pkt->sk rather than skb->sknet/ | +4 | 0 replies | |
| 3/7 | netfilter: add NF_INET_LOCAL_SOCKET_IN chain typeinclude/ net/ net/ +1 more | +7 | 11 replies | |
| 4/7 | net: tcp_ipv4, udp_ipv4: hook up LOCAL_SOCKET_IN netfilter chainsnet/ net/ net/ | +28 | 0 replies | |
| 5/7 | net: tcp_ipv6, udp_ipv6: hook up LOCAL_SOCKET_IN netfilter chainsnet/ net/ net/ | +25 | 0 replies | |
| 6/7 | net: sctp: hook up LOCAL_SOCKET_IN netfilter chainsnet/ | +10 | 0 replies | |
| 7/7 | net: dccp: hook up LOCAL_SOCKET_IN netfilter chainsnet/ net/ | +26 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RFC 0/7] netfilter: introduce new chain type for local socket input
Here is a patch set that enables for full support for match rules that take into account information about the local receiver socket.
Such rules allow administrators to implement per-application or per-container firewalls which filter any type of network traffic directed to or originated from a set of processes on a system, independent of, for instance, local or remote port numbers.
In theory, such rules are already supported through the 'meta' and 'socket' rule types, but they currently do not work for ingress packets delivered to unestablished listener sockets. NF_INET_LOCAL_IN chains are iterated once the IP stack decides a packet is directed to the local system, but before the local listener socket is determined. Consequently, filter rules that are based on information derived from the listener socket cannot be used reliably.
This patch set introduces a new chain type (NF_INET_LOCAL_SOCKET_IN) that is iterated at a later point in time than NF_INET_LOCAL_IN, after the listener socket demux has succeeded. Chains of this type are hence only looked at _if_ there is a local listener.
The input paths for TCP and UDP for IPv4 and IPv6 are patched for the new hook-up, as well as SCTP and DCCP.
Possible performance penalties for setups in which this new type is not used need to be considered, but I lack a good test case for that. I'm sure some people reading this do have proper test scenarios they can run with these patches applied. I'd be very interested in these numbers.
For SCTP and DCCP, I admittedly lack a proper test case as well, and for UDP, I'm aware of a possible deadlock due to nf_hook() being called under hslot->lock when the stack is flushed preliminarily from __udp[46]_lib_mcast_deliver(). That's fixable, but I've kept it simple for this RFC.
Only nftables is supported so far, but enabling iptables as well would be straight forward.
I also have trivial patches for libnftnl and nftables to enable the userspace part.
I'd appreciate some feedback about this approach.
Thanks,
Daniel
Daniel Mack (7):
netfilter: add socket to struct nft_pktinfo
netfilter: nft_meta: look at pkt->sk rather than skb->sk
netfilter: add NF_INET_LOCAL_SOCKET_IN chain type
net: tcp_ipv4, udp_ipv4: hook up LOCAL_SOCKET_IN netfilter chains
net: tcp_ipv6, udp_ipv6: hook up LOCAL_SOCKET_IN netfilter chains
net: sctp: hook up LOCAL_SOCKET_IN netfilter chains
net: dccp: hook up LOCAL_SOCKET_IN netfilter chains
include/net/netfilter/nf_tables.h | 2 ++ include/uapi/linux/netfilter.h | 1 + net/dccp/ipv4.c | 14 +++++++++++++- net/dccp/ipv6.c | 14 +++++++++++++- net/ipv4/netfilter/iptable_filter.c | 1 + net/ipv4/netfilter/nf_tables_ipv4.c | 14 ++++++++------ net/ipv4/tcp_ipv4.c | 8 ++++++++ net/ipv4/udp.c | 15 +++++++++++++++ net/ipv6/netfilter/nf_tables_ipv6.c | 14 ++++++++------ net/ipv6/tcp_ipv6.c | 8 ++++++++ net/ipv6/udp.c | 9 +++++++++ net/netfilter/nf_tables_inet.c | 3 ++- net/netfilter/nft_meta.c | 7 ++++--- net/sctp/input.c | 11 ++++++++++- 14 files changed, 102 insertions(+), 19 deletions(-)
Signature · 1 line
2.5.0