Skip to content

target-i386: Fix undefined behavior on bit shifts

Eduardo Habkost qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2target-i386: Use 1UL for bit shifttarget-i386/cpu.c+1 -116 replies
2/2target-i386: Don't left shift negative constanttarget-i386/translate.c+1 -14 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] target-i386: Fix undefined behavior on bit shifts

This fixes two errors detected by clang:

target-i386/cpu.c:1494:15: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' target-i386/translate.c:2423:26: runtime error: left shift of negative value -8

Eduardo Habkost (2):
target-i386: Use 1UL for bit shift
target-i386: Don't left shift negative constant

 target-i386/cpu.c       | 2 +-
 target-i386/translate.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.1.0