Skip to content

Lustre (mostly locking) unused code removal

[email protected] lkml lustre-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest32 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32staging/lustre/llite: Remove unused ll_get_default/max_cookiesize()drivers/staging/lustre/lustre/llite/llite_internal.h drivers/staging/lustre/lustre/llite/llite_lib.c+0 -280 replies
2/32staging/lustre: KEY_DEFAULT/MAX_COOKIESIZE key is unused, remove themdrivers/staging/lustre/lustre/include/obd.h drivers/staging/lustre/lustre/lmv/lmv_obd.c drivers/staging/lustre/lustre/mdc/mdc_request.c+0 -240 replies
3/32staging/lustre: Remove ununused ll_ra_read_get()drivers/staging/lustre/lustre/llite/llite_internal.h drivers/staging/lustre/lustre/llite/rw.c+0 -250 replies
4/32staging/lustre/llite: Remove unused ll_rmdir_entry()drivers/staging/lustre/lustre/llite/llite_internal.h drivers/staging/lustre/lustre/llite/namei.c+0 -290 replies
5/32staging/lustre/lov: Remove unused lov_dump_lmm/pool()drivers/staging/lustre/lustre/lov/lov_internal.h drivers/staging/lustre/lustre/lov/lov_pack.c drivers/staging/lustre/lustre/lov/lov_pool.c+0 -440 replies
6/32staging/lustre/lov: Remove unused lov_lsm_decref()drivers/staging/lustre/lustre/lov/lov_cl_internal.h drivers/staging/lustre/lustre/lov/lov_object.c+1 -150 replies
7/32staging/lustre/ldlm: Remove unused interval tree bitsdrivers/staging/lustre/lustre/include/interval_tree.h drivers/staging/lustre/lustre/ldlm/interval_tree.c+0 -3070 replies
8/32staging/lustre/ldlm: Remove unused ldlm_cancel_locks_for_exports()drivers/staging/lustre/lustre/ldlm/ldlm_internal.h drivers/staging/lustre/lustre/ldlm/ldlm_lock.c+0 -520 replies
9/32staging/lustre/ldlm: Remove ldlm_init/destroy_export()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c+0 -1070 replies
10/32staging/lustre/ldlm: Remove unimplemented lock conversion traces.drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_lock.c drivers/staging/lustre/lustre/ldlm/ldlm_request.c+0 -2240 replies
11/32staging/lustre/ldlm: Get rid of lr_converting queuedrivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_lock.c drivers/staging/lustre/lustre/ldlm/ldlm_request.c +1 more+1 -320 replies
12/32staging/lustre/ldlm: Remove unused ldlm_cli_enqueue_local()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_request.c+0 -830 replies
13/32staging/lustre/ldlm: Remove unused ldlm_init/fini_flock_exportdrivers/staging/lustre/lustre/ldlm/ldlm_flock.c drivers/staging/lustre/lustre/ldlm/ldlm_internal.h+0 -1040 replies
14/32staging/lustre/ldlm: Remove unused ldlm_enqueue_pack()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_request.c+0 -220 replies
15/32staging/lustre/ldlm: Remove ldlm_errno2error()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_lib.c+1 -380 replies
16/32staging/lustre/ldlm: Remove ldlm_glimpse_ast()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_request.c+0 -290 replies
17/32staging/lustre/ldlm: Remove ldlm_lock_fail_match()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_lock.c+0 -90 replies
18/32staging/lustre/ldlm: Remove ldlm_namespace_free()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_resource.c+0 -290 replies
19/32staging/lustre/ldlm: Remove unused ldlm_pool_get_clv()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_pool.c+0 -170 replies
20/32staging/lustre/ldlm: Remove unused ldlm_pool_set_slv()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_pool.c+0 -140 replies
21/32staging/lustre/ldlm: Remove ldlm_refresh/del_waiting_lock()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_lock.c drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c+0 -230 replies
22/32staging/lustre/ldlm: Remove intent policies handler.drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_lock.c+13 -800 replies
23/32staging/lustre/ldlm: Remove unused ldlm_reprocess_all*()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_flock.c drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +1 more+0 -550 replies
24/32staging/lustre/ldlm: Remove unused ldlm_resource_insert_lock_after()drivers/staging/lustre/lustre/ldlm/ldlm_internal.h drivers/staging/lustre/lustre/ldlm/ldlm_resource.c+0 -280 replies
25/32staging/lustre/ldlm: Remove unused ldlm_blocking_ast/_nocheck()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_request.c+0 -730 replies
26/32staging/lustre: Remove ns_is_client()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_flock.c drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +2 more+17 -670 replies
27/32staging/lustre: Remove ns_is_server()drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/l_lock.c drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +1 more+4 -460 replies
28/32staging/lustre/ldlm: Remove server side code from pool support.drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_pool.c+13 -3380 replies
29/32staging/lustre/ldlm: Remove unused exported symbols.drivers/staging/lustre/lustre/include/lustre_dlm.h drivers/staging/lustre/lustre/ldlm/ldlm_extent.c drivers/staging/lustre/lustre/ldlm/ldlm_flock.c +6 more+111 -1510 replies
30/32staging/lustre/ldlm: Remove ldlm_namespace_inactive_list()drivers/staging/lustre/lustre/ldlm/ldlm_internal.h drivers/staging/lustre/lustre/ldlm/ldlm_resource.c+3 -110 replies
31/32staging/lustre/ldlm: Remove posix lock (flock) deadlock detectiondrivers/staging/lustre/lustre/ldlm/ldlm_flock.c+0 -1320 replies
32/32staging/lustre/ldlm: Make ldlm_add_ast_work_item() staticdrivers/staging/lustre/lustre/ldlm/ldlm_internal.h drivers/staging/lustre/lustre/ldlm/ldlm_lock.c+3 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/32] Lustre (mostly locking) unused code removal

From: Oleg Drokin <[email protected]>

This continues the quest for killing unused code in the Lustre client.

Main focus in this set is on Lustre LDLM code - it kills both outright unused code and code that looks like it's used, but in fact also unused as various conditions that would lead to it would only happen on the server. Also LDLM is cleaned up to remove unneeded exported symbols and (almost) all locally used functions are now declared as static.

Also a few patches to llite/lov to remove some unused functions there.

Please consider.

Oleg Drokin (32):
staging/lustre/llite: Remove unused ll_get_default/max_cookiesize() staging/lustre: KEY_DEFAULT/MAX_COOKIESIZE key is unused, remove them staging/lustre: Remove ununused ll_ra_read_get() staging/lustre/llite: Remove unused ll_rmdir_entry() staging/lustre/lov: Remove unused lov_dump_lmm/pool() staging/lustre/lov: Remove unused lov_lsm_decref() staging/lustre/ldlm: Remove unused interval tree bits staging/lustre/ldlm: Remove unused ldlm_cancel_locks_for_exports() staging/lustre/ldlm: Remove ldlm_init/destroy_export() staging/lustre/ldlm: Remove unimplemented lock conversion traces. staging/lustre/ldlm: Get rid of lr_converting queue staging/lustre/ldlm: Remove unused ldlm_cli_enqueue_local() staging/lustre/ldlm: Remove unused ldlm_init/fini_flock_export staging/lustre/ldlm: Remove unused ldlm_enqueue_pack() staging/lustre/ldlm: Remove ldlm_errno2error() staging/lustre/ldlm: Remove ldlm_glimpse_ast() staging/lustre/ldlm: Remove ldlm_lock_fail_match() staging/lustre/ldlm: Remove ldlm_namespace_free() staging/lustre/ldlm: Remove unused ldlm_pool_get_clv() staging/lustre/ldlm: Remove unused ldlm_pool_set_slv() staging/lustre/ldlm: Remove ldlm_refresh/del_waiting_lock() staging/lustre/ldlm: Remove intent policies handler. staging/lustre/ldlm: Remove unused ldlm_reprocess_all*() staging/lustre/ldlm: Remove unused ldlm_resource_insert_lock_after() staging/lustre/ldlm: Remove unused ldlm_blocking_ast/_nocheck() staging/lustre: Remove ns_is_client()
staging/lustre: Remove ns_is_server()
staging/lustre/ldlm: Remove server side code from pool support. staging/lustre/ldlm: Remove unused exported symbols. staging/lustre/ldlm: Remove ldlm_namespace_inactive_list() staging/lustre/ldlm: Remove posix lock (flock) deadlock detection staging/lustre/ldlm: Make ldlm_add_ast_work_item() static

 .../staging/lustre/lustre/include/interval_tree.h  |  36 --
 drivers/staging/lustre/lustre/include/lustre_dlm.h | 103 +----
 drivers/staging/lustre/lustre/include/obd.h        |   2 -
 drivers/staging/lustre/lustre/ldlm/interval_tree.c | 271 --------------
 drivers/staging/lustre/lustre/ldlm/l_lock.c        |   7 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_extent.c   |  22 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_flock.c    | 269 +------------
 drivers/staging/lustre/lustre/ldlm/ldlm_internal.h |  36 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_lib.c      |  36 --
 drivers/staging/lustre/lustre/ldlm/ldlm_lock.c     | 380 ++-----------------
 drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c    | 122 +-----
 drivers/staging/lustre/lustre/ldlm/ldlm_pool.c     | 416 ++-------------------
 drivers/staging/lustre/lustre/ldlm/ldlm_request.c  | 338 +----------------
 drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 181 +++------
 .../staging/lustre/lustre/llite/llite_internal.h   |   4 -
 drivers/staging/lustre/lustre/llite/llite_lib.c    |  26 --
 drivers/staging/lustre/lustre/llite/namei.c        |  28 --
 drivers/staging/lustre/lustre/llite/rw.c           |  24 --
 drivers/staging/lustre/lustre/lmv/lmv_obd.c        |   2 -
 .../staging/lustre/lustre/lov/lov_cl_internal.h    |   3 -
 drivers/staging/lustre/lustre/lov/lov_internal.h   |   2 -
 drivers/staging/lustre/lustre/lov/lov_object.c     |  13 +-
 drivers/staging/lustre/lustre/lov/lov_pack.c       |  20 -
 drivers/staging/lustre/lustre/lov/lov_pool.c       |  22 --
 drivers/staging/lustre/lustre/mdc/mdc_request.c    |  20 -
 25 files changed, 155 insertions(+), 2228 deletions(-)
Signature · 1 line
2.1.0