qom: more efficient object property handling
Status from this message: I have queued things up to 6/7 on qom-next:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 33 repliesApplied
- v35 patches 14 repliesSuperseded
Changes in v4 from the cover letter
- Create ObjectPropertyIterator struct to allow inline iteration, instead of using callback functions
- Convert spapr and net filter code to new iterators too
- Extend check-qom-proplist.c test to cover new iterators and class property usage
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | qom: introduce ObjectPropertyIterator struct for iterationinclude/ qom/ tests/ | +127 | 4 replies | |
| 2/7 | qmp: convert QMP code to use object property iteratorsqmp.c | +8 | 2 replies | |
| 3/7 | vl: convert machine help code to use object property iteratorsvl.c | +4 | 1 reply | |
| 4/7 | ppc: convert spapr code to use object property iteratorshw/ | +4 | 1 reply | |
| 5/7 | net: convert net filter code to use object property iteratorsnet/ | +4 | 1 reply | |
| 6/7 | qom: replace object property list with GHashTableinclude/ qom/ | +64 | 17 replies | |
| 7/7 | qom: allow properties to be registered against classesinclude/ qom/ tests/ | +293 | 4 replies |
Reviews trailers per patch
4 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Pavel Fedin | Andreas Färber |
|---|---|---|
| Series | T-b | |
| 1/7 | ||
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | ||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling
This patch series is a followup to
v3: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02024.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05953.html
+
https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg01455.htmlThis series introduces a concept of object property iterators to QOM so callers are insulated from the specific data structures used for storing properties against objects/classes. It then converts Object to use a GHashTable for storing properties. Finally it introduces ObjectClass properties.
Probably the only controversial thing is the item Pavel points out about object_child_foreach iterators now being forbidden from modifying the object composition tree.
Changed in v4:
- Create ObjectPropertyIterator struct to allow inline iteration, instead of using callback functions
- Convert spapr and net filter code to new iterators too
- Extend check-qom-proplist.c test to cover new iterators and class property usage
Daniel P. Berrange (6):
qom: introduce ObjectPropertyIterator struct for iteration
qmp: convert QMP code to use object property iterators
vl: convert machine help code to use object property iterators
ppc: convert spapr code to use object property iterators
net: convert net filter code to use object property iterators
qom: allow properties to be registered against classes
Pavel Fedin (1):
qom: replace object property list with GHashTable
hw/ppc/spapr_drc.c | 5 +- include/qom/object.h | 110 ++++++++++++++- net/filter.c | 5 +- qmp.c | 10 +- qom/object.c | 328 ++++++++++++++++++++++++++++++++++++++++----- tests/check-qom-proplist.c | 77 +++++++++-- vl.c | 5 +- 7 files changed, 485 insertions(+), 55 deletions(-)
Signature · 1 line
2.4.3