Skip to content

Staging: rtl8712: Fix coding style warnings

Punit Vara lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/22 of 4 patches 0 repliesNew
  2. v1 posting 1/24 patches 9 repliesSuperseded

2 of 4 patches are in this archive. The cover letter announces 4.

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset()drivers/staging/rtl8712/rtl871x_ioctl_linux.c+1 -20 replies
3/4Staging: rtl8712: Coding style warnings fix for block commentsdrivers/staging/rtl8712/rtl871x_ioctl_linux.c+15 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings

This set of patch fixes following warnings reported by checkpatch.pl:

-Prefer eth_broadcast_addr() over memset()
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() -Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line -Comparisons should place the constant on the right side of the test

v2: Fixed API suggested by : Larry Finger [email protected]
Improved patch description suggested by Julia [email protected]
Punit Vara (4):
Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over
memset()
Staging: rtl8712: Use ether_addr_equal() over memcmp()
Staging: rtl8712: Coding style warnings fix for block comments
Staging: rtl8712: fix warning for placing constant on the right side
of test

 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 47 ++++++++++++++-------------
 1 file changed, 25 insertions(+), 22 deletions(-)

--
2.5.3